Skip to content

Commit 8502966

Browse files
fix(client): return binary content from get /containers/{container_id}/files/{file_id}/content
1 parent 71c3d31 commit 8502966

File tree

4 files changed

+6
-16
lines changed

4 files changed

+6
-16
lines changed

.stats.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
configured_endpoints: 111
22
openapi_spec_url: https://storage.googleapis.com/stainless-sdk-openapi-specs/openai%2Fopenai-d4bcffecf0cdadf746faa6708ed1ec81fac451f9b857deabbab26f0a343b9314.yml
33
openapi_spec_hash: 7c54a18b4381248bda7cc34c52142615
4-
config_hash: 2102e4b25bbcab5d32d5ffa5d34daa0c
4+
config_hash: d23f847b9ebb3f427d0f198035bd3e9f

api.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -809,4 +809,4 @@ Methods:
809809

810810
Methods:
811811

812-
- <code title="get /containers/{container_id}/files/{file_id}/content">client.containers.files.content.<a href="./src/resources/containers/files/content.ts">retrieve</a>(containerId, fileId) -> void</code>
812+
- <code title="get /containers/{container_id}/files/{file_id}/content">client.containers.files.content.<a href="./src/resources/containers/files/content.ts">retrieve</a>(containerId, fileId) -> Response</code>

src/resources/containers/files/content.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,15 +2,17 @@
22

33
import { APIResource } from '../../../resource';
44
import * as Core from '../../../core';
5+
import { type Response } from '../../../_shims/index';
56

67
export class Content extends APIResource {
78
/**
89
* Retrieve Container File Content
910
*/
10-
retrieve(containerId: string, fileId: string, options?: Core.RequestOptions): Core.APIPromise<void> {
11+
retrieve(containerId: string, fileId: string, options?: Core.RequestOptions): Core.APIPromise<Response> {
1112
return this._client.get(`/containers/${containerId}/files/${fileId}/content`, {
1213
...options,
13-
headers: { Accept: '*/*', ...options?.headers },
14+
headers: { Accept: 'application/binary', ...options?.headers },
15+
__binaryResponse: true,
1416
});
1517
}
1618
}

tests/api-resources/containers/files/content.test.ts

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,25 +1,13 @@
11
// File generated from our OpenAPI spec by Stainless. See CONTRIBUTING.md for details.
22

33
import OpenAI from 'openai';
4-
import { Response } from 'node-fetch';
54

65
const client = new OpenAI({
76
apiKey: 'My API Key',
87
baseURL: process.env['TEST_API_BASE_URL'] ?? 'http://127.0.0.1:4010',
98
});
109

1110
describe('resource content', () => {
12-
test('retrieve', async () => {
13-
const responsePromise = client.containers.files.content.retrieve('container_id', 'file_id');
14-
const rawResponse = await responsePromise.asResponse();
15-
expect(rawResponse).toBeInstanceOf(Response);
16-
const response = await responsePromise;
17-
expect(response).not.toBeInstanceOf(Response);
18-
const dataAndResponse = await responsePromise.withResponse();
19-
expect(dataAndResponse.data).toBe(response);
20-
expect(dataAndResponse.response).toBe(rawResponse);
21-
});
22-
2311
test('retrieve: request options instead of params are passed correctly', async () => {
2412
// ensure the request options are being passed correctly by passing an invalid HTTP method in order to cause an error
2513
await expect(

0 commit comments

Comments
 (0)