Skip to content

Commit c407da7

Browse files
If the externalauth flag is set, don't attempt to parse out a user name
and password since there won't be any!
1 parent 82d17ac commit c407da7

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

doc/src/release_notes.rst

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ Thick Mode Changes
2424

2525
#) Fixed bug when using external authentication with a TNS alias
2626
(`issue 178 <https://github.com/oracle/python-oracledb/issues/178>`__).
27+
#) Fixed bug when using external authentication with an EZ connect string.
2728

2829
Common Changes
2930
++++++++++++++

src/oracledb/impl/base/connect_params.pyx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -608,7 +608,7 @@ cdef class ConnectParamsImpl:
608608
"""
609609
if kwargs:
610610
self.set(kwargs)
611-
if self.user is None and dsn is not None:
611+
if self.user is None and not self.externalauth and dsn is not None:
612612
user, password, dsn = self.parse_dsn_with_credentials(dsn)
613613
self.set(dict(user=user, password=password))
614614
if dsn is not None and thin:

0 commit comments

Comments
 (0)