GH1264 Version 2.0 cleanup #1265
Conversation
pandas-stubs/core/indexes/base.pyi
Outdated
| def union(self, other: list[HashableT] | Index, sort=...) -> Index: ... | ||
| def intersection(self, other: list[S1] | Self, sort: bool = ...) -> Self: ... | ||
| def union( | ||
| self, other: list[HashableT] | Index, sort: bool | None = ... |
There was a problem hiding this comment.
| self, other: list[HashableT] | Index, sort: bool | None = ... | |
| self, other: list[HashableT] | Self, sort: bool | None = ... |
Might as well be consistent with these different operations
pandas-stubs/core/series.pyi
Outdated
| @@ -2324,6 +2324,13 @@ class TimedeltaSeries(Series[Timedelta]): | |||
| *args: Any, | |||
| **kwargs: Any, | |||
| ) -> TimedeltaSeries: ... | |||
| def cumprod( | |||
| self, | |||
| axis: AxisIndex | None = ..., | |||
There was a problem hiding this comment.
Since the default argument is None, wouldn't that cause issues?
There was a problem hiding this comment.
According to https://pandas.pydata.org/pandas-docs/stable/reference/api/pandas.Series.cumprod.html#pandas.Series.cumprod the default argument is 0
There was a problem hiding this comment.
I see what you mean, I was looking at the 2.3.0 code which still has None as default but on main it is now 0 (I would not see anyone use None by default and otherwise it will make it a good time to fix it).
tests/test_indexes.py
Outdated
| pd.RangeIndex(0, 10).union(["a", "b", "c"], sort=True), | ||
| Union[pd.Index, "pd.Index[int]", pd.RangeIndex], | ||
| ), | ||
| pd.Index, | ||
| ) | ||
| check( | ||
| assert_type( | ||
| pd.RangeIndex(0, 10).union(["a", "b", "c"], sort=False), | ||
| Union[pd.Index, "pd.Index[int]", pd.RangeIndex], | ||
| ), |
There was a problem hiding this comment.
This doesn't seem right, and I think you'll need some specific overloads here for RangeIndex (and Sequence[int] for that matter). If RangeIndex has a set operation with either a Sequence[int], Series[int], Index[int] or RangeIndex, the result is Union[RangeIndex, Index[int]]. With any other type, it is just Index
There was a problem hiding this comment.
Indeed that was the wrong copy paste, this is fixed.
tests/test_series.py
Outdated
| @@ -3941,3 +3941,8 @@ def test_series_index_type() -> None: | |||
|
|
|||
| if TYPE_CHECKING_INVALID_USAGE: | |||
| t = pd.Series([1, 2], index="ab") # type: ignore[call-overload] # pyright: ignore[reportCallIssue, reportArgumentType] | |||
|
|
|||
|
|
|||
| def test_timedelta_index_cumsum() -> None: | |||
There was a problem hiding this comment.
| def test_timedelta_index_cumsum() -> None: | |
| def test_timedelta_invalid_cumprod() -> None: |
assert_type()to assert the type of any return value