CLN: Use pandas.compat instead of sys.version_info for Python version checks (#20545)

Author: jschendel

pandas/_version.py

@@ -12,6 +12,7 @@
 import re
 import subprocess
 import sys
+from pandas.compat import PY3
 
 
 def get_keywords():
@@ -83,7 +84,7 @@ def run_command(commands, args, cwd=None, verbose=False, hide_stderr=False):
             print("unable to find command, tried %s" % (commands,))
         return None
     stdout = p.communicate()[0].strip()
-    if sys.version_info[0] >= 3:
+    if PY3:
         stdout = stdout.decode()
     if p.returncode != 0:
         if verbose:

pandas/compat/__init__.py

@@ -369,7 +369,7 @@ def callable(obj):
         return any("__call__" in klass.__dict__ for klass in type(obj).__mro__)
 
 
-if sys.version_info[0] < 3:
+if PY2:
     # In PY2 functools.wraps doesn't provide metadata pytest needs to generate
     # decorated tests using parametrization. See pytest GH issue #2782
     def wraps(wrapped, assigned=functools.WRAPPER_ASSIGNMENTS,

pandas/io/clipboard/clipboards.py

@@ -1,12 +1,10 @@
-import sys
 import subprocess
 from .exceptions import PyperclipException
+from pandas.compat import PY2, text_type
 
 EXCEPT_MSG = """
     Pyperclip could not find a copy/paste mechanism for your system.
     For more information, please visit https://pyperclip.readthedocs.org """
-PY2 = sys.version_info[0] == 2
-text_type = unicode if PY2 else str  # noqa
 
 
 def init_osx_clipboard():

pandas/io/formats/terminal.py

@@ -14,8 +14,9 @@
 from __future__ import print_function
 
 import os
-import sys
 import shutil
+from pandas.compat import PY3
+
 
 __all__ = ['get_terminal_size', 'is_terminal']
 
@@ -29,7 +30,7 @@ def get_terminal_size():
     """
     import platform
 
-    if sys.version_info[0] >= 3:
+    if PY3:
         return shutil.get_terminal_size()
 
     current_os = platform.system()

pandas/tests/frame/test_analytics.py

@@ -4,9 +4,7 @@
 
 import warnings
 from datetime import timedelta
-from distutils.version import LooseVersion
 import operator
-import sys
 import pytest
 
 from string import ascii_lowercase
@@ -1857,13 +1855,8 @@ def test_round(self):
             'col1': [1.123, 2.123, 3.123],
             'col2': [1.2, 2.2, 3.2]})
 
-        if LooseVersion(sys.version) < LooseVersion('2.7'):
-            # Rounding with decimal is a ValueError in Python < 2.7
-            with pytest.raises(ValueError):
-                df.round(nan_round_Series)
-        else:
-            with pytest.raises(TypeError):
-                df.round(nan_round_Series)
+        with pytest.raises(TypeError):
+            df.round(nan_round_Series)
 
         # Make sure this doesn't break existing Series.round
         tm.assert_series_equal(df['col1'].round(1), expected_rounded['col1'])

pandas/tests/frame/test_api.py

@@ -7,8 +7,6 @@
 # pylint: disable-msg=W0612,E1101
 from copy import deepcopy
 import pydoc
-import sys
-from distutils.version import LooseVersion
 
 from pandas.compat import range, lrange, long
 from pandas import compat
@@ -253,18 +251,14 @@ def test_itertuples(self):
                     '[(0, 1, 4), (1, 2, 5), (2, 3, 6)]')
 
         tup = next(df.itertuples(name='TestName'))
-
-        if LooseVersion(sys.version) >= LooseVersion('2.7'):
-            assert tup._fields == ('Index', 'a', 'b')
-            assert (tup.Index, tup.a, tup.b) == tup
-            assert type(tup).__name__ == 'TestName'
+        assert tup._fields == ('Index', 'a', 'b')
+        assert (tup.Index, tup.a, tup.b) == tup
+        assert type(tup).__name__ == 'TestName'
 
         df.columns = ['def', 'return']
         tup2 = next(df.itertuples(name='TestName'))
         assert tup2 == (0, 1, 4)
-
-        if LooseVersion(sys.version) >= LooseVersion('2.7'):
-            assert tup2._fields == ('Index', '_1', '_2')
+        assert tup2._fields == ('Index', '_1', '_2')
 
         df3 = DataFrame({'f' + str(i): [i] for i in range(1024)})
         # will raise SyntaxError if trying to create namedtuple

pandas/tests/indexes/datetimes/test_tools.py

@@ -1,6 +1,5 @@
 """ test to_datetime """
 
-import sys
 import pytz
 import pytest
 import locale
@@ -149,9 +148,6 @@ def test_to_datetime_with_non_exact(self, cache):
         # GH 10834
         # 8904
         # exact kw
-        if sys.version_info < (2, 7):
-            pytest.skip('on python version < 2.7')
-
         s = Series(['19MAY11', 'foobar19MAY11', '19MAY11:00:00:00',
                     '19MAY11 00:00:00Z'])
         result = to_datetime(s, format='%d%b%y', exact=False, cache=cache)

pandas/tests/io/formats/test_format.py

@@ -1256,8 +1256,6 @@ def test_to_string_float_formatting(self):
 
         df_s = df.to_string()
 
-        # Python 2.5 just wants me to be sad. And debian 32-bit
-        # sys.version_info[0] == 2 and sys.version_info[1] < 6:
         if _three_digit_exp():
             expected = ('              x\n0  0.00000e+000\n1  2.50000e-001\n'
                         '2  3.45600e+003\n3  1.20000e+046\n4  1.64000e+006\n'
@@ -1281,8 +1279,7 @@ def test_to_string_float_formatting(self):
 
         df = DataFrame({'x': [1e9, 0.2512]})
         df_s = df.to_string()
-        # Python 2.5 just wants me to be sad. And debian 32-bit
-        # sys.version_info[0] == 2 and sys.version_info[1] < 6:
+
         if _three_digit_exp():
             expected = ('               x\n'
                         '0  1.000000e+009\n'

pandas/tests/io/parser/common.py

@@ -1275,10 +1275,8 @@ def test_verbose_import(self):
         else:  # Python engine
             assert output == 'Filled 1 NA values in column a\n'
 
+    @pytest.mark.skipif(PY3, reason="won't work in Python 3")
     def test_iteration_open_handle(self):
-        if PY3:
-            pytest.skip(
-                "won't work in Python 3 {0}".format(sys.version_info))
 
         with tm.ensure_clean() as path:
             with open(path, 'wb') as f:

pandas/tests/io/test_excel.py

@@ -1,6 +1,5 @@
 # pylint: disable=E1101
 import os
-import sys
 import warnings
 from datetime import datetime, date, time, timedelta
 from distutils.version import LooseVersion
@@ -16,7 +15,7 @@
 import pandas.util.testing as tm
 import pandas.util._test_decorators as td
 from pandas import DataFrame, Index, MultiIndex
-from pandas.compat import u, range, map, BytesIO, iteritems
+from pandas.compat import u, range, map, BytesIO, iteritems, PY36
 from pandas.core.config import set_option, get_option
 from pandas.io.common import URLError
 from pandas.io.excel import (
@@ -585,9 +584,6 @@ def test_read_from_s3_url(self, ext):
     def test_read_from_file_url(self, ext):
 
         # FILE
-        if sys.version_info[:2] < (2, 6):
-            pytest.skip("file:// not supported with Python < 2.6")
-
         localtable = os.path.join(self.dirpath, 'test1' + ext)
         local_table = read_excel(localtable)
 
@@ -2314,9 +2310,9 @@ def custom_converter(css):
 
 
 @td.skip_if_no('openpyxl')
+@pytest.mark.skipif(not PY36, reason='requires fspath')
 class TestFSPath(object):
 
-    @pytest.mark.skipif(sys.version_info < (3, 6), reason='requires fspath')
     def test_excelfile_fspath(self):
         with tm.ensure_clean('foo.xlsx') as path:
             df = DataFrame({"A": [1, 2]})
@@ -2325,8 +2321,6 @@ def test_excelfile_fspath(self):
             result = os.fspath(xl)
             assert result == path
 
-    @pytest.mark.skipif(sys.version_info < (3, 6), reason='requires fspath')
-    # @pytest.mark.xfail
     def test_excelwriter_fspath(self):
         with tm.ensure_clean('foo.xlsx') as path:
             writer = ExcelWriter(path)