STYLE use absolute imports (#39561)

MarcoGorelli · web-flow · commit 9a52a81fa669 · 2021-02-03T08:48:01.000-05:00
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
@@ -195,3 +195,8 @@ repos:
     rev: v0.1.7
     hooks:
     -   id: no-string-hints
+-   repo: https://github.com/MarcoGorelli/abs-imports
+    rev: v0.1.2
+    hooks:
+    -   id: abs-imports
+        files: ^pandas/
diff --git a/pandas/__init__.py b/pandas/__init__.py
@@ -180,7 +180,7 @@
 import pandas.arrays
 
 # use the closest tagged version if possible
-from ._version import get_versions
+from pandas._version import get_versions
 
 v = get_versions()
 __version__ = v.get("closest-tag", v["version"])
diff --git a/pandas/_libs/tslibs/__init__.py b/pandas/_libs/tslibs/__init__.py
@@ -27,18 +27,28 @@
     "tz_compare",
 ]
 
-from . import dtypes
-from .conversion import OutOfBoundsTimedelta, localize_pydatetime
-from .dtypes import Resolution
-from .nattype import NaT, NaTType, iNaT, is_null_datetimelike, nat_strings
-from .np_datetime import OutOfBoundsDatetime
-from .offsets import BaseOffset, Tick, to_offset
-from .period import IncompatibleFrequency, Period
-from .timedeltas import Timedelta, delta_to_nanoseconds, ints_to_pytimedelta
-from .timestamps import Timestamp
-from .timezones import tz_compare
-from .tzconversion import tz_convert_from_utc_single
-from .vectorized import (
+from pandas._libs.tslibs import dtypes
+from pandas._libs.tslibs.conversion import OutOfBoundsTimedelta, localize_pydatetime
+from pandas._libs.tslibs.dtypes import Resolution
+from pandas._libs.tslibs.nattype import (
+    NaT,
+    NaTType,
+    iNaT,
+    is_null_datetimelike,
+    nat_strings,
+)
+from pandas._libs.tslibs.np_datetime import OutOfBoundsDatetime
+from pandas._libs.tslibs.offsets import BaseOffset, Tick, to_offset
+from pandas._libs.tslibs.period import IncompatibleFrequency, Period
+from pandas._libs.tslibs.timedeltas import (
+    Timedelta,
+    delta_to_nanoseconds,
+    ints_to_pytimedelta,
+)
+from pandas._libs.tslibs.timestamps import Timestamp
+from pandas._libs.tslibs.timezones import tz_compare
+from pandas._libs.tslibs.tzconversion import tz_convert_from_utc_single
+from pandas._libs.tslibs.vectorized import (
     dt64arr_to_periodarr,
     get_resolution,
     ints_to_pydatetime,
diff --git a/pandas/core/arrays/boolean.py b/pandas/core/arrays/boolean.py
@@ -23,8 +23,7 @@
 from pandas.core.dtypes.missing import isna
 
 from pandas.core import ops
-
-from .masked import BaseMaskedArray, BaseMaskedDtype
+from pandas.core.arrays.masked import BaseMaskedArray, BaseMaskedDtype
 
 if TYPE_CHECKING:
     import pyarrow
diff --git a/pandas/core/arrays/floating.py b/pandas/core/arrays/floating.py
@@ -23,11 +23,10 @@
 from pandas.core.dtypes.dtypes import ExtensionDtype, register_extension_dtype
 from pandas.core.dtypes.missing import isna
 
+from pandas.core.arrays.numeric import NumericArray, NumericDtype
 from pandas.core.ops import invalid_comparison
 from pandas.core.tools.numeric import to_numeric
 
-from .numeric import NumericArray, NumericDtype
-
 
 class FloatingDtype(NumericDtype):
     """
diff --git a/pandas/core/arrays/integer.py b/pandas/core/arrays/integer.py
@@ -23,12 +23,11 @@
 )
 from pandas.core.dtypes.missing import isna
 
+from pandas.core.arrays.masked import BaseMaskedArray, BaseMaskedDtype
+from pandas.core.arrays.numeric import NumericArray, NumericDtype
 from pandas.core.ops import invalid_comparison
 from pandas.core.tools.numeric import to_numeric
 
-from .masked import BaseMaskedArray, BaseMaskedDtype
-from .numeric import NumericArray, NumericDtype
-
 
 class _IntegerDtype(NumericDtype):
     """
diff --git a/pandas/core/arrays/numeric.py b/pandas/core/arrays/numeric.py
@@ -18,8 +18,7 @@
 )
 
 from pandas.core import ops
-
-from .masked import BaseMaskedArray, BaseMaskedDtype
+from pandas.core.arrays.masked import BaseMaskedArray, BaseMaskedDtype
 
 if TYPE_CHECKING:
     import pyarrow
diff --git a/pandas/core/arrays/timedeltas.py b/pandas/core/arrays/timedeltas.py
@@ -419,7 +419,7 @@ def _add_period(self, other: Period):
         Add a Period object.
         """
         # We will wrap in a PeriodArray and defer to the reversed operation
-        from .period import PeriodArray
+        from pandas.core.arrays.period import PeriodArray
 
         i8vals = np.broadcast_to(other.ordinal, self.shape)
         oth = PeriodArray(i8vals, freq=other.freq)
diff --git a/pandas/core/strings/__init__.py b/pandas/core/strings/__init__.py
@@ -26,7 +26,7 @@
 #     - PandasArray
 #     - Categorical
 
-from .accessor import StringMethods
-from .base import BaseStringArrayMethods
+from pandas.core.strings.accessor import StringMethods
+from pandas.core.strings.base import BaseStringArrayMethods
 
 __all__ = ["StringMethods", "BaseStringArrayMethods"]
diff --git a/pandas/tests/api/test_types.py b/pandas/tests/api/test_types.py
@@ -1,7 +1,6 @@
 import pandas._testing as tm
 from pandas.api import types
-
-from .test_api import Base
+from pandas.tests.api.test_api import Base
 
 
 class TestTypes(Base):
diff --git a/pandas/tests/arithmetic/test_period.py b/pandas/tests/arithmetic/test_period.py
@@ -14,8 +14,7 @@
 import pandas._testing as tm
 from pandas.core import ops
 from pandas.core.arrays import TimedeltaArray
-
-from .common import assert_invalid_comparison
+from pandas.tests.arithmetic.common import assert_invalid_comparison
 
 # ------------------------------------------------------------------
 # Comparisons
diff --git a/pandas/tests/extension/arrow/test_bool.py b/pandas/tests/extension/arrow/test_bool.py
@@ -8,7 +8,10 @@
 
 pytest.importorskip("pyarrow", minversion="0.13.0")
 
-from .arrays import ArrowBoolArray, ArrowBoolDtype  # isort:skip
+from pandas.tests.extension.arrow.arrays import (  # isort:skip
+    ArrowBoolArray,
+    ArrowBoolDtype,
+)
 
 
 @pytest.fixture
diff --git a/pandas/tests/extension/arrow/test_string.py b/pandas/tests/extension/arrow/test_string.py
@@ -4,7 +4,7 @@
 
 pytest.importorskip("pyarrow", minversion="0.13.0")
 
-from .arrays import ArrowStringDtype  # isort:skip
+from pandas.tests.extension.arrow.arrays import ArrowStringDtype  # isort:skip
 
 
 def test_constructor_from_list():
diff --git a/pandas/tests/extension/arrow/test_timestamp.py b/pandas/tests/extension/arrow/test_timestamp.py
@@ -12,7 +12,7 @@
 
 import pyarrow as pa  # isort:skip
 
-from .arrays import ArrowExtensionArray  # isort:skip
+from pandas.tests.extension.arrow.arrays import ArrowExtensionArray  # isort:skip
 
 
 @register_extension_dtype
diff --git a/pandas/tests/extension/base/__init__.py b/pandas/tests/extension/base/__init__.py
@@ -41,26 +41,26 @@ class TestMyDtype(BaseDtypeTests):
 ``assert_series_equal`` on your base test class.
 
 """
-from .casting import BaseCastingTests  # noqa
-from .constructors import BaseConstructorsTests  # noqa
-from .dtype import BaseDtypeTests  # noqa
-from .getitem import BaseGetitemTests  # noqa
-from .groupby import BaseGroupbyTests  # noqa
-from .interface import BaseInterfaceTests  # noqa
-from .io import BaseParsingTests  # noqa
-from .methods import BaseMethodsTests  # noqa
-from .missing import BaseMissingTests  # noqa
-from .ops import (  # noqa
+from pandas.tests.extension.base.casting import BaseCastingTests  # noqa
+from pandas.tests.extension.base.constructors import BaseConstructorsTests  # noqa
+from pandas.tests.extension.base.dtype import BaseDtypeTests  # noqa
+from pandas.tests.extension.base.getitem import BaseGetitemTests  # noqa
+from pandas.tests.extension.base.groupby import BaseGroupbyTests  # noqa
+from pandas.tests.extension.base.interface import BaseInterfaceTests  # noqa
+from pandas.tests.extension.base.io import BaseParsingTests  # noqa
+from pandas.tests.extension.base.methods import BaseMethodsTests  # noqa
+from pandas.tests.extension.base.missing import BaseMissingTests  # noqa
+from pandas.tests.extension.base.ops import (  # noqa
     BaseArithmeticOpsTests,
     BaseComparisonOpsTests,
     BaseOpsUtil,
     BaseUnaryOpsTests,
 )
-from .printing import BasePrintingTests  # noqa
-from .reduce import (  # noqa
+from pandas.tests.extension.base.printing import BasePrintingTests  # noqa
+from pandas.tests.extension.base.reduce import (  # noqa
     BaseBooleanReduceTests,
     BaseNoReduceTests,
     BaseNumericReduceTests,
 )
-from .reshaping import BaseReshapingTests  # noqa
-from .setitem import BaseSetitemTests  # noqa
+from pandas.tests.extension.base.reshaping import BaseReshapingTests  # noqa
+from pandas.tests.extension.base.setitem import BaseSetitemTests  # noqa
diff --git a/pandas/tests/extension/base/casting.py b/pandas/tests/extension/base/casting.py
@@ -3,8 +3,7 @@
 
 import pandas as pd
 from pandas.core.internals import ObjectBlock
-
-from .base import BaseExtensionTests
+from pandas.tests.extension.base.base import BaseExtensionTests
 
 
 class BaseCastingTests(BaseExtensionTests):
diff --git a/pandas/tests/extension/base/constructors.py b/pandas/tests/extension/base/constructors.py
@@ -3,8 +3,7 @@
 
 import pandas as pd
 from pandas.core.internals import ExtensionBlock
-
-from .base import BaseExtensionTests
+from pandas.tests.extension.base.base import BaseExtensionTests
 
 
 class BaseConstructorsTests(BaseExtensionTests):
diff --git a/pandas/tests/extension/base/dtype.py b/pandas/tests/extension/base/dtype.py
@@ -5,8 +5,7 @@
 
 import pandas as pd
 from pandas.api.types import is_object_dtype, is_string_dtype
-
-from .base import BaseExtensionTests
+from pandas.tests.extension.base.base import BaseExtensionTests
 
 
 class BaseDtypeTests(BaseExtensionTests):
diff --git a/pandas/tests/extension/base/getitem.py b/pandas/tests/extension/base/getitem.py
@@ -2,8 +2,7 @@
 import pytest
 
 import pandas as pd
-
-from .base import BaseExtensionTests
+from pandas.tests.extension.base.base import BaseExtensionTests
 
 
 class BaseGetitemTests(BaseExtensionTests):
diff --git a/pandas/tests/extension/base/groupby.py b/pandas/tests/extension/base/groupby.py
@@ -2,8 +2,7 @@
 
 import pandas as pd
 import pandas._testing as tm
-
-from .base import BaseExtensionTests
+from pandas.tests.extension.base.base import BaseExtensionTests
 
 
 class BaseGroupbyTests(BaseExtensionTests):
diff --git a/pandas/tests/extension/base/interface.py b/pandas/tests/extension/base/interface.py
@@ -5,8 +5,7 @@
 
 import pandas as pd
 import pandas._testing as tm
-
-from .base import BaseExtensionTests
+from pandas.tests.extension.base.base import BaseExtensionTests
 
 
 class BaseInterfaceTests(BaseExtensionTests):
diff --git a/pandas/tests/extension/base/io.py b/pandas/tests/extension/base/io.py
@@ -4,8 +4,7 @@
 import pytest
 
 import pandas as pd
-
-from .base import BaseExtensionTests
+from pandas.tests.extension.base.base import BaseExtensionTests
 
 
 class BaseParsingTests(BaseExtensionTests):
diff --git a/pandas/tests/extension/base/methods.py b/pandas/tests/extension/base/methods.py
@@ -9,8 +9,7 @@
 import pandas as pd
 import pandas._testing as tm
 from pandas.core.sorting import nargsort
-
-from .base import BaseExtensionTests
+from pandas.tests.extension.base.base import BaseExtensionTests
 
 
 class BaseMethodsTests(BaseExtensionTests):
diff --git a/pandas/tests/extension/base/missing.py b/pandas/tests/extension/base/missing.py
@@ -2,8 +2,7 @@
 
 import pandas as pd
 import pandas._testing as tm
-
-from .base import BaseExtensionTests
+from pandas.tests.extension.base.base import BaseExtensionTests
 
 
 class BaseMissingTests(BaseExtensionTests):
diff --git a/pandas/tests/extension/base/ops.py b/pandas/tests/extension/base/ops.py
@@ -5,8 +5,7 @@
 import pandas as pd
 import pandas._testing as tm
 from pandas.core import ops
-
-from .base import BaseExtensionTests
+from pandas.tests.extension.base.base import BaseExtensionTests
 
 
 class BaseOpsUtil(BaseExtensionTests):
diff --git a/pandas/tests/extension/base/printing.py b/pandas/tests/extension/base/printing.py
@@ -3,8 +3,7 @@
 import pytest
 
 import pandas as pd
-
-from .base import BaseExtensionTests
+from pandas.tests.extension.base.base import BaseExtensionTests
 
 
 class BasePrintingTests(BaseExtensionTests):
diff --git a/pandas/tests/extension/base/reduce.py b/pandas/tests/extension/base/reduce.py
@@ -4,8 +4,7 @@
 
 import pandas as pd
 import pandas._testing as tm
-
-from .base import BaseExtensionTests
+from pandas.tests.extension.base.base import BaseExtensionTests
 
 
 class BaseReduceTests(BaseExtensionTests):
diff --git a/pandas/tests/extension/base/reshaping.py b/pandas/tests/extension/base/reshaping.py
@@ -5,8 +5,7 @@
 
 import pandas as pd
 from pandas.core.internals import ExtensionBlock
-
-from .base import BaseExtensionTests
+from pandas.tests.extension.base.base import BaseExtensionTests
 
 
 class BaseReshapingTests(BaseExtensionTests):
diff --git a/pandas/tests/extension/base/setitem.py b/pandas/tests/extension/base/setitem.py
@@ -3,8 +3,7 @@
 
 import pandas as pd
 import pandas._testing as tm
-
-from .base import BaseExtensionTests
+from pandas.tests.extension.base.base import BaseExtensionTests
 
 
 class BaseSetitemTests(BaseExtensionTests):
diff --git a/pandas/tests/extension/decimal/__init__.py b/pandas/tests/extension/decimal/__init__.py
@@ -1,3 +1,8 @@
-from .array import DecimalArray, DecimalDtype, make_data, to_decimal
+from pandas.tests.extension.decimal.array import (
+    DecimalArray,
+    DecimalDtype,
+    make_data,
+    to_decimal,
+)
 
 __all__ = ["DecimalArray", "DecimalDtype", "to_decimal", "make_data"]
diff --git a/pandas/tests/extension/decimal/test_decimal.py b/pandas/tests/extension/decimal/test_decimal.py
@@ -8,8 +8,12 @@
 import pandas as pd
 import pandas._testing as tm
 from pandas.tests.extension import base
-
-from .array import DecimalArray, DecimalDtype, make_data, to_decimal
+from pandas.tests.extension.decimal.array import (
+    DecimalArray,
+    DecimalDtype,
+    make_data,
+    to_decimal,
+)
 
 
 @pytest.fixture
diff --git a/pandas/tests/extension/json/__init__.py b/pandas/tests/extension/json/__init__.py
@@ -1,3 +1,3 @@
-from .array import JSONArray, JSONDtype, make_data
+from pandas.tests.extension.json.array import JSONArray, JSONDtype, make_data
 
 __all__ = ["JSONArray", "JSONDtype", "make_data"]
diff --git a/pandas/tests/extension/json/test_json.py b/pandas/tests/extension/json/test_json.py
@@ -6,8 +6,7 @@
 import pandas as pd
 import pandas._testing as tm
 from pandas.tests.extension import base
-
-from .array import JSONArray, JSONDtype, make_data
+from pandas.tests.extension.json.array import JSONArray, JSONDtype, make_data
 
 
 @pytest.fixture
diff --git a/pandas/tests/extension/list/__init__.py b/pandas/tests/extension/list/__init__.py
diff --git a/pandas/tests/extension/list/test_list.py b/pandas/tests/extension/list/test_list.py
diff --git a/pandas/tests/extension/test_numpy.py b/pandas/tests/extension/test_numpy.py
diff --git a/pandas/tests/generic/test_frame.py b/pandas/tests/generic/test_frame.py
diff --git a/pandas/tests/generic/test_series.py b/pandas/tests/generic/test_series.py
diff --git a/pandas/tests/indexes/categorical/test_category.py b/pandas/tests/indexes/categorical/test_category.py
diff --git a/pandas/tests/indexes/datetimelike.py b/pandas/tests/indexes/datetimelike.py
diff --git a/pandas/tests/indexes/datetimes/test_datetimelike.py b/pandas/tests/indexes/datetimes/test_datetimelike.py
diff --git a/pandas/tests/indexes/period/test_period.py b/pandas/tests/indexes/period/test_period.py
diff --git a/pandas/tests/indexes/ranges/test_range.py b/pandas/tests/indexes/ranges/test_range.py
diff --git a/pandas/tests/indexes/timedeltas/test_timedelta.py b/pandas/tests/indexes/timedeltas/test_timedelta.py
diff --git a/pandas/tests/indexing/test_indexing.py b/pandas/tests/indexing/test_indexing.py
diff --git a/pandas/tests/tseries/offsets/test_ticks.py b/pandas/tests/tseries/offsets/test_ticks.py
diff --git a/versioneer.py b/versioneer.py

Original file line number	Diff line number	Diff line change
`@@ -18,8 +18,7 @@`
`18`	`18`	`)`
`19`	`19`
`20`	`20`	`from pandas.core import ops`
`21`		`-`
`22`		`-from .masked import BaseMaskedArray, BaseMaskedDtype`
	`21`	`+from pandas.core.arrays.masked import BaseMaskedArray, BaseMaskedDtype`
`23`	`22`
`24`	`23`	`if TYPE_CHECKING:`
`25`	`24`	`import pyarrow`