Skip to content

Commit cc4859a

Browse files
committed
fix test_maybe_convert_i8_numeric
1 parent 8cc670a commit cc4859a

File tree

1 file changed

+15
-18
lines changed

1 file changed

+15
-18
lines changed

pandas/tests/indexes/interval/test_interval.py

Lines changed: 15 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -18,10 +18,7 @@
1818
timedelta_range,
1919
)
2020
import pandas._testing as tm
21-
from pandas.core.api import (
22-
Float64Index,
23-
NumericIndex,
24-
)
21+
from pandas.core.api import Float64Index
2522
import pandas.core.common as com
2623

2724

@@ -417,33 +414,33 @@ def test_maybe_convert_i8_nat(self, breaks):
417414
result = index._maybe_convert_i8(to_convert)
418415
tm.assert_index_equal(result, expected)
419416

420-
@pytest.mark.parametrize(
421-
"breaks",
422-
[np.arange(5, dtype="int64"), np.arange(5, dtype="float64")],
423-
ids=lambda x: str(x.dtype),
424-
)
417+
def test_maybe_convert_i8_numeric(self, any_real_numpy_dtype):
418+
# GH 20636
419+
breaks = np.arange(5, dtype=any_real_numpy_dtype)
420+
index = IntervalIndex.from_breaks(breaks)
421+
422+
result = index._maybe_convert_i8(breaks)
423+
expected = Index(breaks)
424+
tm.assert_index_equal(result, expected)
425+
425426
@pytest.mark.parametrize(
426427
"make_key",
427428
[
428429
IntervalIndex.from_breaks,
429430
lambda breaks: Interval(breaks[0], breaks[1]),
430-
lambda breaks: breaks,
431431
lambda breaks: breaks[0],
432-
list,
433432
],
434-
ids=["IntervalIndex", "Interval", "Index", "scalar", "list"],
433+
ids=["IntervalIndex", "Interval", "scalar"],
435434
)
436-
def test_maybe_convert_i8_numeric(self, breaks, make_key):
435+
def test_maybe_convert_i8_numeric_identical(self, make_key, any_real_numpy_dtype):
437436
# GH 20636
437+
breaks = np.arange(5, dtype=any_real_numpy_dtype)
438438
index = IntervalIndex.from_breaks(breaks)
439439
key = make_key(breaks)
440440

441+
# test if _maybe_convert_i8 won't change key if an Interval or IntervalIndex
441442
result = index._maybe_convert_i8(key)
442-
if not isinstance(result, NumericIndex):
443-
assert result is key
444-
else:
445-
expected = NumericIndex(key)
446-
tm.assert_index_equal(result, expected)
443+
assert result is key
447444

448445
@pytest.mark.parametrize(
449446
"breaks1, breaks2",

0 commit comments

Comments
 (0)