-
-
Notifications
You must be signed in to change notification settings - Fork 18.7k
Closed
Labels
Typingtype annotations, mypy/pyright type checkingtype annotations, mypy/pyright type checkinggood first issue
Description
This method is declared as final
:
Lines 3629 to 3630 in 526d52f
@final | |
def _take_with_is_copy(self: FrameOrSeries, indices, axis=0) -> FrameOrSeries: |
It's then overridden in series
:
Line 866 in 526d52f
def _take_with_is_copy(self, indices, axis=0): |
The reason mypy
doesn't detect this failure is that the override in series
in untyped, and so mypy
doesn't check it
@jbrockmendel do you know which one is correct? Remove final
or remove the override?
Metadata
Metadata
Assignees
Labels
Typingtype annotations, mypy/pyright type checkingtype annotations, mypy/pyright type checkinggood first issue