-
-
Notifications
You must be signed in to change notification settings - Fork 18.7k
Remove unused functions, cimports #19360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #19360 +/- ##
==========================================
+ Coverage 91.54% 91.58% +0.03%
==========================================
Files 150 150
Lines 48702 48694 -8
==========================================
+ Hits 44585 44595 +10
+ Misses 4117 4099 -18
Continue to review full report at Codecov.
|
or isinstance(obj, list) and len(obj) == cnt \ | ||
or getattr(obj, 'shape', None) == (cnt,): | ||
if (util.is_array(obj) or | ||
isinstance(obj, list) and len(obj) == cnt or |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could do PyListCheck here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or change the other below, I find this slightly non-idiomatic
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like cython automatically converts to PyList_Check
.
Agreed on a lot of the idiomatic point. There's a lot of built-up debris in _libs.
thanks! |
Miscellaneous cleanup, use
util.is_array
instead ofisinstance
, that kind of thing.git diff upstream/master -u -- "*.py" | flake8 --diff