From 1f91ae605f8d5915e3fd0258241ed18478c049b0 Mon Sep 17 00:00:00 2001 From: Marc Garcia Date: Thu, 21 Nov 2019 21:57:23 +0000 Subject: [PATCH 1/3] DOC: Updating documentation of new required pytest version --- doc/source/development/contributing.rst | 2 +- doc/source/getting_started/install.rst | 2 +- doc/source/whatsnew/v1.0.0.rst | 1 + 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/doc/source/development/contributing.rst b/doc/source/development/contributing.rst index 042d6926d84f5..d7b3e159f8ce7 100644 --- a/doc/source/development/contributing.rst +++ b/doc/source/development/contributing.rst @@ -946,7 +946,7 @@ extensions in `numpy.testing .. note:: - The earliest supported pytest version is 4.0.2. + The earliest supported pytest version is 5.0.1. Writing tests ~~~~~~~~~~~~~ diff --git a/doc/source/getting_started/install.rst b/doc/source/getting_started/install.rst index 663948fd46cf6..3ba3a2fd4be1b 100644 --- a/doc/source/getting_started/install.rst +++ b/doc/source/getting_started/install.rst @@ -177,7 +177,7 @@ pandas is equipped with an exhaustive set of unit tests, covering about 97% of the code base as of this writing. To run it on your machine to verify that everything is working (and that you have all of the dependencies, soft and hard, installed), make sure you have `pytest -`__ >= 4.0.2 and `Hypothesis +`__ >= 5.0.1 and `Hypothesis `__ >= 3.58, then run: :: diff --git a/doc/source/whatsnew/v1.0.0.rst b/doc/source/whatsnew/v1.0.0.rst index 54640ff576338..6cbf655db4a44 100644 --- a/doc/source/whatsnew/v1.0.0.rst +++ b/doc/source/whatsnew/v1.0.0.rst @@ -253,6 +253,7 @@ Other API changes See :ref:`units registration ` for more. - :meth:`Series.dropna` has dropped its ``**kwargs`` argument in favor of a single ``how`` parameter. Supplying anything else than ``how`` to ``**kwargs`` raised a ``TypeError`` previously (:issue:`29388`) +- When testing pandas, the new minimum required version of pytest is 5.0.1 (:issue:`29664`) - From 8da8ac02139010defa14068ce118de37edc60f20 Mon Sep 17 00:00:00 2001 From: Marc Garcia Date: Fri, 22 Nov 2019 01:09:48 +0000 Subject: [PATCH 2/3] Updating pytest min version in error message --- pandas/util/_tester.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pandas/util/_tester.py b/pandas/util/_tester.py index 0f5324c8d02ba..7822ecdeeb4d8 100644 --- a/pandas/util/_tester.py +++ b/pandas/util/_tester.py @@ -11,7 +11,7 @@ def test(extra_args=None): try: import pytest except ImportError: - raise ImportError("Need pytest>=4.0.2 to run tests") + raise ImportError("Need pytest>=5.0.1 to run tests") try: import hypothesis # noqa except ImportError: From 1a4a414599196570d077cfa56def73b6e0e4d448 Mon Sep 17 00:00:00 2001 From: Marc Garcia Date: Fri, 22 Nov 2019 01:13:12 +0000 Subject: [PATCH 3/3] Addig pytest to compat min versions --- pandas/compat/_optional.py | 1 + 1 file changed, 1 insertion(+) diff --git a/pandas/compat/_optional.py b/pandas/compat/_optional.py index fc66502710b0c..ce9079ce8864d 100644 --- a/pandas/compat/_optional.py +++ b/pandas/compat/_optional.py @@ -18,6 +18,7 @@ "pandas_gbq": "0.8.0", "pyarrow": "0.9.0", "pytables": "3.4.2", + "pytest": "5.0.1", "s3fs": "0.3.0", "scipy": "0.19.0", "sqlalchemy": "1.1.4",