From d4f5fdb20c13f1acc64aebe5b34d098c9a4ed4fa Mon Sep 17 00:00:00 2001 From: Daniel Saxton Date: Sun, 9 Feb 2020 08:47:53 -0600 Subject: [PATCH 1/3] DOC: Fix style guide typos --- doc/source/development/code_style.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/source/development/code_style.rst b/doc/source/development/code_style.rst index a295038b5a0bd..37affb07bec59 100644 --- a/doc/source/development/code_style.rst +++ b/doc/source/development/code_style.rst @@ -119,14 +119,14 @@ For example: .. code-block:: python value = str - f"Unknown recived value, got: {repr(value)}" + f"Unknown received value, got: {repr(value)}" **Good:** .. code-block:: python value = str - f"Unknown recived type, got: '{type(value).__name__}'" + f"Unknown received type, got: '{type(value).__name__}'" Imports (aim for absolute) From c91f381d2fce3bba1f8f8d6c6be90eee5a7049eb Mon Sep 17 00:00:00 2001 From: Daniel Saxton Date: Sun, 9 Feb 2020 09:00:54 -0600 Subject: [PATCH 2/3] Is -> are --- doc/source/development/code_style.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/source/development/code_style.rst b/doc/source/development/code_style.rst index 37affb07bec59..ae80fa0f29337 100644 --- a/doc/source/development/code_style.rst +++ b/doc/source/development/code_style.rst @@ -139,7 +139,7 @@ absolute imports that show the whole import chain from toplevel pandas. Explicit relative imports are also supported in Python 3. But it is not recommended to use it. Implicit relative imports should never be used -and is removed in Python 3. +and are removed in Python 3. For example: From 6122b6c36f4758fa69328b5479f1492b8ada6c3a Mon Sep 17 00:00:00 2001 From: Daniel Saxton Date: Sun, 9 Feb 2020 09:03:31 -0600 Subject: [PATCH 3/3] Edit spelling / grammar --- doc/source/development/code_style.rst | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/doc/source/development/code_style.rst b/doc/source/development/code_style.rst index ae80fa0f29337..bcddc033a61f5 100644 --- a/doc/source/development/code_style.rst +++ b/doc/source/development/code_style.rst @@ -135,10 +135,10 @@ Imports (aim for absolute) In Python 3, absolute imports are recommended. In absolute import doing something like ``import string`` will import the string module rather than ``string.py`` in the same directory. As much as possible, you should try to write out -absolute imports that show the whole import chain from toplevel pandas. +absolute imports that show the whole import chain from top-level pandas. -Explicit relative imports are also supported in Python 3. But it is not -recommended to use it. Implicit relative imports should never be used +Explicit relative imports are also supported in Python 3 but it is not +recommended to use them. Implicit relative imports should never be used and are removed in Python 3. For example: