From 6711cbd86ddc5ff63e707a45f672108c859b0ddf Mon Sep 17 00:00:00 2001
From: jbrockmendel <jbrockmendel@gmail.com>
Date: Sun, 23 Feb 2020 13:26:25 -0800
Subject: [PATCH 1/3] Add CategoricalIndex to IndexCache

---
 asv_bench/benchmarks/categoricals.py            | 3 ---
 asv_bench/benchmarks/index_cached_properties.py | 3 +++
 asv_bench/benchmarks/indexing.py                | 5 +++++
 asv_bench/benchmarks/period.py                  | 3 ---
 asv_bench/benchmarks/timedelta.py               | 3 ---
 5 files changed, 8 insertions(+), 9 deletions(-)

diff --git a/asv_bench/benchmarks/categoricals.py b/asv_bench/benchmarks/categoricals.py
index 6f43a6fd3fc9b..107b9b9edcd5d 100644
--- a/asv_bench/benchmarks/categoricals.py
+++ b/asv_bench/benchmarks/categoricals.py
@@ -258,9 +258,6 @@ def setup(self):
     def time_get_loc(self):
         self.index.get_loc(self.category)
 
-    def time_shape(self):
-        self.index.shape
-
     def time_shallow_copy(self):
         self.index._shallow_copy()
 
diff --git a/asv_bench/benchmarks/index_cached_properties.py b/asv_bench/benchmarks/index_cached_properties.py
index 13b33855569c9..16fbc741775e4 100644
--- a/asv_bench/benchmarks/index_cached_properties.py
+++ b/asv_bench/benchmarks/index_cached_properties.py
@@ -7,6 +7,7 @@ class IndexCache:
 
     params = [
         [
+            "CategoricalIndex",
             "DatetimeIndex",
             "Float64Index",
             "IntervalIndex",
@@ -42,6 +43,8 @@ def setup(self, index_type):
             self.idx = pd.Float64Index(range(N))
         elif index_type == "UInt64Index":
             self.idx = pd.UInt64Index(range(N))
+        elif index_type == "CategoricalIndex":
+            self.idx = pd.CategoricalIndex(range(N), range(N))
         else:
             raise ValueError
         assert len(self.idx) == N
diff --git a/asv_bench/benchmarks/indexing.py b/asv_bench/benchmarks/indexing.py
index 087fe3916845b..e98d2948e76ea 100644
--- a/asv_bench/benchmarks/indexing.py
+++ b/asv_bench/benchmarks/indexing.py
@@ -1,3 +1,8 @@
+"""
+These benchmarks are for Series and DataFrame indexing methods.  For the
+lower-level methods directly on Index and subclasses, see index_object.py,
+indexing_engine.py, and index_cached.py
+"""
 import warnings
 
 import numpy as np
diff --git a/asv_bench/benchmarks/period.py b/asv_bench/benchmarks/period.py
index b52aa2e55af35..e15d4c66e4fc0 100644
--- a/asv_bench/benchmarks/period.py
+++ b/asv_bench/benchmarks/period.py
@@ -85,9 +85,6 @@ def setup(self):
     def time_get_loc(self):
         self.index.get_loc(self.period)
 
-    def time_shape(self):
-        self.index.shape
-
     def time_shallow_copy(self):
         self.index._shallow_copy()
 
diff --git a/asv_bench/benchmarks/timedelta.py b/asv_bench/benchmarks/timedelta.py
index 208c8f9d14a5e..cfe05c3e257b1 100644
--- a/asv_bench/benchmarks/timedelta.py
+++ b/asv_bench/benchmarks/timedelta.py
@@ -73,9 +73,6 @@ def setup(self):
     def time_get_loc(self):
         self.index.get_loc(self.timedelta)
 
-    def time_shape(self):
-        self.index.shape
-
     def time_shallow_copy(self):
         self.index._shallow_copy()
 

From cda3759e5f0bb6f2539b83252cc21aee36c8a299 Mon Sep 17 00:00:00 2001
From: jbrockmendel <jbrockmendel@gmail.com>
Date: Sun, 23 Feb 2020 13:40:31 -0800
Subject: [PATCH 2/3] move is_dates_only benchmark

---
 asv_bench/benchmarks/index_object.py | 8 --------
 asv_bench/benchmarks/timeseries.py   | 3 +++
 2 files changed, 3 insertions(+), 8 deletions(-)

diff --git a/asv_bench/benchmarks/index_object.py b/asv_bench/benchmarks/index_object.py
index cf51a4d35f805..b242de6a17208 100644
--- a/asv_bench/benchmarks/index_object.py
+++ b/asv_bench/benchmarks/index_object.py
@@ -55,14 +55,6 @@ def time_datetime_difference_disjoint(self):
         self.datetime_left.difference(self.datetime_right)
 
 
-class Datetime:
-    def setup(self):
-        self.dr = date_range("20000101", freq="D", periods=10000)
-
-    def time_is_dates_only(self):
-        self.dr._is_dates_only
-
-
 class Range:
     def setup(self):
         self.idx_inc = RangeIndex(start=0, stop=10 ** 7, step=3)
diff --git a/asv_bench/benchmarks/timeseries.py b/asv_bench/benchmarks/timeseries.py
index 2f7ea8b9c0873..2fecc3afb7373 100644
--- a/asv_bench/benchmarks/timeseries.py
+++ b/asv_bench/benchmarks/timeseries.py
@@ -57,6 +57,9 @@ def time_to_date(self, index_type):
     def time_to_pydatetime(self, index_type):
         self.index.to_pydatetime()
 
+    def time_is_dates_only(self):
+        self.index._is_dates_only
+
 
 class TzLocalize:
 

From 9d27209b350e8f53c4c62ec84b335f58e431a8cb Mon Sep 17 00:00:00 2001
From: jbrockmendel <jbrockmendel@gmail.com>
Date: Sun, 23 Feb 2020 17:47:56 -0800
Subject: [PATCH 3/3] missing param

---
 asv_bench/benchmarks/timeseries.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/asv_bench/benchmarks/timeseries.py b/asv_bench/benchmarks/timeseries.py
index 2fecc3afb7373..2cc9bc8d4621e 100644
--- a/asv_bench/benchmarks/timeseries.py
+++ b/asv_bench/benchmarks/timeseries.py
@@ -57,7 +57,7 @@ def time_to_date(self, index_type):
     def time_to_pydatetime(self, index_type):
         self.index.to_pydatetime()
 
-    def time_is_dates_only(self):
+    def time_is_dates_only(self, index_type):
         self.index._is_dates_only