add Juneteenth to USFederalHolidayCalendar #42328
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you write a test for this. |
twoertwein
reviewed
Jul 2, 2021
pandas/tseries/holiday.py
Outdated
| @@ -559,6 +559,7 @@ class USFederalHolidayCalendar(AbstractHolidayCalendar): | |||
| USMartinLutherKingJr, | |||
| USPresidentsDay, | |||
| USMemorialDay, | |||
| Holiday("Juneteenth", month=6, day=19, observance=nearest_workday), | |||
There was a problem hiding this comment.
Should probably be "Juneteenth National Independence Day" https://www.opm.gov/policy-data-oversight/pay-leave/federal-holidays/#url=2021
|
Hello @ChuliangXiao! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-07-02 15:35:29 UTC |
|
Thanks @ChuliangXiao, besides the test, can you also please an entry in the release notes? Thanks! |
|
This pull request is stale because it has been open for thirty days with no activity. Please update or respond to this comment if you're still interested in working on this. |
|
Closing as stale, but if you want to finish this @ChuliangXiao just let me know. |
1 task
mroeschke
pushed a commit
that referenced
this pull request
Nov 29, 2021
* add Juneteenth to USFederalHolidayCalendar * Standardize federal holiday names Reference https://www.opm.gov/policy-data-oversight/pay-leave/federal-holidays/#url=2021 * short long code line * ENH: Holidays: add Juneteenth start_date (#42328, #44574) Co-authored-by: Chuliang Xiao <[email protected]> Co-authored-by: Jeff Reback <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Juneteenth National Independence Day
Standardize the official federal holiday names