From de0579ba899fde85fcaeba77722521963a30c067 Mon Sep 17 00:00:00 2001 From: jackgoldsmith4 Date: Mon, 6 Jun 2022 22:06:26 -0400 Subject: [PATCH 1/5] add test --- pandas/tests/indexing/test_loc.py | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/pandas/tests/indexing/test_loc.py b/pandas/tests/indexing/test_loc.py index 1e5e65786a4aa..0e5bfac9e284e 100644 --- a/pandas/tests/indexing/test_loc.py +++ b/pandas/tests/indexing/test_loc.py @@ -2869,6 +2869,13 @@ def test_loc_setitem_using_datetimelike_str_as_index(fill_val, exp_dtype): tm.assert_index_equal(df.index, expected_index, exact=True) +def test_loc_set_int_dtype(): + df = pd.DataFrame([list('abc')]) + df.loc[:, 'col1'] = int(5) + + assert str(df.dtypes['col1']) == 'int64' + + class TestLocSeries: @pytest.mark.parametrize("val,expected", [(2**63 - 1, 3), (2**63, 4)]) def test_loc_uint64(self, val, expected): From 0941d15d5859441725fb0980ad3590d345df72d8 Mon Sep 17 00:00:00 2001 From: jackgoldsmith4 Date: Mon, 6 Jun 2022 23:38:38 -0400 Subject: [PATCH 2/5] double quotes --- pandas/tests/indexing/test_loc.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pandas/tests/indexing/test_loc.py b/pandas/tests/indexing/test_loc.py index 0e5bfac9e284e..8760fdf5fb206 100644 --- a/pandas/tests/indexing/test_loc.py +++ b/pandas/tests/indexing/test_loc.py @@ -2870,10 +2870,10 @@ def test_loc_setitem_using_datetimelike_str_as_index(fill_val, exp_dtype): def test_loc_set_int_dtype(): - df = pd.DataFrame([list('abc')]) - df.loc[:, 'col1'] = int(5) + df = pd.DataFrame([list("abc")]) + df.loc[:, "col1"] = int(5) - assert str(df.dtypes['col1']) == 'int64' + assert str(df.dtypes["col1"]) == "int64" class TestLocSeries: From 7decd54fad6ad73aa04fca376fcbab7c29ccbb4a Mon Sep 17 00:00:00 2001 From: jackgoldsmith4 Date: Wed, 8 Jun 2022 22:13:57 -0400 Subject: [PATCH 3/5] fixes --- pandas/tests/indexing/test_loc.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/pandas/tests/indexing/test_loc.py b/pandas/tests/indexing/test_loc.py index 8760fdf5fb206..7395147baaa97 100644 --- a/pandas/tests/indexing/test_loc.py +++ b/pandas/tests/indexing/test_loc.py @@ -2870,10 +2870,12 @@ def test_loc_setitem_using_datetimelike_str_as_index(fill_val, exp_dtype): def test_loc_set_int_dtype(): + # GH#23326 df = pd.DataFrame([list("abc")]) - df.loc[:, "col1"] = int(5) + df.loc[:, "col1"] = 5 - assert str(df.dtypes["col1"]) == "int64" + expected = DataFrame({'0': ['a'], '1': ['b'], '2': ['c'], 'col1': [5]}) + tm.assert_frame_equal(df, expected) class TestLocSeries: From 8e12cf86886c7bab580f7ad59b625cdf960f0939 Mon Sep 17 00:00:00 2001 From: jackgoldsmith4 Date: Wed, 8 Jun 2022 22:19:21 -0400 Subject: [PATCH 4/5] remove pd --- pandas/tests/indexing/test_loc.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pandas/tests/indexing/test_loc.py b/pandas/tests/indexing/test_loc.py index 7395147baaa97..dff938d15add6 100644 --- a/pandas/tests/indexing/test_loc.py +++ b/pandas/tests/indexing/test_loc.py @@ -2871,7 +2871,7 @@ def test_loc_setitem_using_datetimelike_str_as_index(fill_val, exp_dtype): def test_loc_set_int_dtype(): # GH#23326 - df = pd.DataFrame([list("abc")]) + df = DataFrame([list("abc")]) df.loc[:, "col1"] = 5 expected = DataFrame({'0': ['a'], '1': ['b'], '2': ['c'], 'col1': [5]}) From 858b76537a566f56958b126bc2f296f49a52b04b Mon Sep 17 00:00:00 2001 From: jackgoldsmith4 Date: Thu, 9 Jun 2022 20:30:32 -0400 Subject: [PATCH 5/5] fix index type --- pandas/tests/indexing/test_loc.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pandas/tests/indexing/test_loc.py b/pandas/tests/indexing/test_loc.py index dff938d15add6..9b1cb69cc33ad 100644 --- a/pandas/tests/indexing/test_loc.py +++ b/pandas/tests/indexing/test_loc.py @@ -2874,7 +2874,7 @@ def test_loc_set_int_dtype(): df = DataFrame([list("abc")]) df.loc[:, "col1"] = 5 - expected = DataFrame({'0': ['a'], '1': ['b'], '2': ['c'], 'col1': [5]}) + expected = DataFrame({0: ["a"], 1: ["b"], 2: ["c"], "col1": [5]}) tm.assert_frame_equal(df, expected)