Override object state from User.logIn and decode

Author: rdhelms

src/Cloud.js

@@ -121,7 +121,6 @@ const DefaultController = {
       if (typeof res === 'object' && Object.keys(res).length > 0 && !res.hasOwnProperty('result')) {
         throw new ParseError(ParseError.INVALID_JSON, 'The server returned an invalid response.');
       }
-      ParseObject._clearAllState();
       const decoded = decode(res);
       if (decoded && decoded.hasOwnProperty('result')) {
         return Promise.resolve(decoded.result);

src/ParseObject.js

@@ -347,10 +347,13 @@ class ParseObject {
     };
   }
 
-  _finishFetch(serverData: AttributeMap) {
+  _finishFetch(serverData: AttributeMap, override?: boolean) {
     if (!this.id && serverData.objectId) {
       this.id = serverData.objectId;
     }
+    if (override) {
+      this._clearServerData();
+    }
     const stateController = CoreManager.getObjectStateController();
     stateController.initializeState(this._getStateIdentifier());
     const decoded = {};

src/ParseUser.js

@@ -1088,8 +1088,7 @@ const DefaultController = {
         stateController.setPendingOp(user._getStateIdentifier(), 'username', undefined);
         stateController.setPendingOp(user._getStateIdentifier(), 'password', undefined);
         response.password = undefined;
-        user._clearServerData();
-        user._finishFetch(response);
+        user._finishFetch(response, true);
         if (!canUseCurrentUser) {
           // We can't set the current user, so just return the one we logged in
           return Promise.resolve(user);

src/decode.js

@@ -34,7 +34,7 @@ export default function decode(value: any): any {
     return ParseObject.fromJSON(value);
   }
   if (value.__type === 'Object' && value.className) {
-    return ParseObject.fromJSON(value);
+    return ParseObject.fromJSON(value, true);
   }
   if (value.__type === 'Relation') {
     // The parent and key fields will be populated by the parent