More flow typing, fixing some undefined issues

Author: andrewimm

src/ObjectStore.js

@@ -40,11 +40,15 @@ var queryHash = require('./QueryTools').queryHash;
 
 // Stores the last known true state of each object, as well as the hashes of
 // queries subscribed to the object.
-var store: { [id: Id]:
-  { data: any; queries: { [hash: string]: boolean } } } = {};
+var store: {
+  [id: Id]: {
+    data: { [attr: string]: any };
+    queries: { [hash: string]: boolean }
+  }
+} = {};
 
 // Stores the queries subscribed to local-only objects
-var localSubscribers = {};
+var localSubscribers: { [id: Id]: { [hash: string]: boolean } } = {};
 
 // Stores a stack of pending mutations for each object
 var pendingMutations: { [id: Id]: Array<{
@@ -62,7 +66,7 @@ var mutationCount = 0;
  * storeObject: takes a flattened object as the single argument, and places it
  * in the Store, indexed by its Id.
  */
-function storeObject(data): Id {
+function storeObject(data: { [attr: string]: any }): Id {
   if (!(data.id instanceof Id)) {
     throw new Error('Cannot store an object without an Id');
   }
@@ -270,7 +274,8 @@ function commitDelta(delta: Delta):
  * Returns an array of object Ids, or an array of maps containing Ids and query-
  * specific ordering information.
  */
-function storeQueryResults(results, query): Array<Id | { id: Id; ordering: any }> {
+function storeQueryResults(results: Array<ParseObject> | ParseObject, query: ParseQuery):
+    Array<Id | { id: Id; ordering: any }> {
   var hash = queryHash(query);
   if (!Array.isArray(results)) {
     results = [results];
@@ -362,7 +367,7 @@ function deepFetch(id: Id, seen?: Array<string>) {
   var obj = {};
   for (var attr in source) {
     var sourceVal = source[attr];
-    if (sourceVal.__type === 'Pointer') {
+    if (typeof sourceVal === 'object' && sourceVal.__type === 'Pointer') {
       var childId = new Id(sourceVal.className, sourceVal.objectId);
       if (seen.indexOf(childId.toString()) < 0 && store[childId]) {
         seen = seen.concat([childId.toString()]);

src/QueryTools.js

@@ -18,6 +18,7 @@
  *  FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
  *  IN THE SOFTWARE.
  *
+ *  @flow
  */
 
 'use strict';
@@ -50,12 +51,12 @@ function flattenOrQueries(where) {
 /**
  * Deterministically turns an object into a string. Disregards ordering
  */
-function stringify(object) {
+function stringify(object): string {
   if (typeof object !== 'object') {
     if (typeof object === 'string') {
       return '"' + object.replace(/\|/g, '%|') + '"';
     }
-    return object;
+    return object + '';
   }
   if (Array.isArray(object)) {
     var copy = object.map(stringify);
@@ -75,12 +76,12 @@ function stringify(object) {
  * Generate a hash from a query, with unique fields for columns, values, order,
  * skip, and limit.
  */
-function queryHash(query) {
+function queryHash(query: ParseQuery): string {
   if (!(query instanceof Parse.Query)) {
     throw new TypeError('Only a Parse Query can be hashed');
   }
   var where = flattenOrQueries(query._where || {});
-  var columns;
+  var columns = [];
   var values = [];
   var i;
   if (Array.isArray(where)) {
@@ -120,7 +121,8 @@ function queryHash(query) {
 /**
  * Extracts the className and keys from a query hash
  */
-function keysFromHash(hash) {
+function keysFromHash(hash: string):
+    { className: string; keys: Array<string> } {
   var classNameSplit = hash.indexOf(':');
   var className = hash.substring(0, classNameSplit);
 
@@ -142,7 +144,9 @@ function keysFromHash(hash) {
  * Since we find queries that match objects, rather than objects that match
  * queries, we can avoid building a full-blown query tool.
  */
-function matchesQuery(object, query) {
+function matchesQuery(
+    object: { [key: string]: any },
+    query: ParseQuery | { [key: string]: any }): boolean {
   if (query instanceof Parse.Query) {
     var className =
       (object.id instanceof Id) ? object.id.className : object.className;

src/SubscriptionManager.js

@@ -98,7 +98,7 @@ function getSubscription(hash: string): ?Subscription {
  * Indexes a query by the fields it depends upon. This lets us quickly find a
  * query that might match an object that has just modified a specific field.
  */
-function indexQuery(query, hash) {
+function indexQuery(query: ParseQuery, hash: string) {
   var fields = keysFromHash(hash).keys;
   if (fields.length < 1) {
     fields = ['']; // Empty string is the key for no WHERE conditions

src/interfaces/ParseObject.interface.js

@@ -0,0 +1,6 @@
+declare class ParseObject {
+  className: string;
+  objectId: string;
+
+  get: (attr: string) => any;
+}