Fix bug that put credentials on the wrong object.

[acinader]

my $.02: this bug, though clearly my error, demonstrates why using non-standard env vars is not a good idea. In order for me to fully test, I have to unset my standard env vars:

AWS_ACCESS_KEY_ID
AWS_DEFAULT_REGION
AWS_SECRET_ACCESS_KEY

and also move my (redundant) ~/.aws config dir.

My suggestion is that this adapter should get a major revision bump that removes the paramters for access key and secret while maintaining the ability to pass them in config object. But in the case that they are passed in the config object they should have the same name that the lib expects: accessKeyId and secretAccessKey.

The two advantages of making this breaking change:

1. promotes use of best security practices from the get go for a new user.
2. removes an unnecessary and somewhat difficult wrinkle in testing.

[acinader]

@flovilmart fixes #15

[codecov-io]

Current coverage is 67.52% (diff: 100%)

No coverage report found for master at 39cacc1.

Powered by Codecov. Last update 39cacc1...3115db9

[acinader]

oh and 3: it would allow for a significant simplification of argument handling reducing potential bugs, increasing maintainability and readability.

[flovilmart]

Alright, let's merge that one.

We can work on 2.0 with the breaking change. And update parse server internals / docs to reflect the breaking change. What do you think?

[acinader]

sounds good. i'll open an issue and you can assign it to me.