Fix bug that put credentials on the wrong object. #19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
my $.02: this bug, though clearly my error, demonstrates why using non-standard env vars is not a good idea. In order for me to fully test, I have to unset my standard env vars:
and also move my (redundant)
~/.aws
config dir.My suggestion is that this adapter should get a major revision bump that removes the paramters for access key and secret while maintaining the ability to pass them in config object. But in the case that they are passed in the config object they should have the same name that the lib expects:
accessKeyId
andsecretAccessKey
.The two advantages of making this breaking change: