Skip to content

Commit 56dc2e4

Browse files
committed
minor change
1 parent 7a651e6 commit 56dc2e4

File tree

1 file changed

+11
-6
lines changed

1 file changed

+11
-6
lines changed

src/triggers.js

Lines changed: 11 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -278,8 +278,7 @@ export function getResponseObject(request, resolve, reject) {
278278
error: function (error) {
279279
// ignore errors thrown in before-delete (during logout for example)
280280
if (isSessionTrigger && request.triggerName === Types.beforeDelete) {
281-
logWarningWhenErrorIsIgnored(request.triggerName, className, error);
282-
return resolve();
281+
return resolve(undefined, error);
283282
}
284283
if (error instanceof Parse.Error) {
285284
reject(error);
@@ -344,12 +343,15 @@ function logTriggerErrorBeforeHook(triggerType, className, input, auth, error) {
344343
);
345344
}
346345

347-
function logWarningWhenErrorIsIgnored(triggerType, className, error) {
346+
function logWarningWhenErrorIsIgnored(triggerType, className, auth, error) {
348347
logger.warn(
349-
`Thrown Error ignored in ${triggerType} trigger for ${className}}\n Error: ${JSON.stringify(error)}`, {
348+
`Error ignored in ${triggerType} for ${className} for user ${userIdForLog(
349+
auth
350+
)}:\n Error: ${JSON.stringify(error)}`, {
350351
className,
351352
triggerType,
352-
error
353+
error,
354+
user: userIdForLog(auth),
353355
}
354356
);
355357
}
@@ -555,7 +557,10 @@ export function maybeRunTrigger(
555557
error
556558
} = getResponseObject(
557559
request,
558-
object => {
560+
(object, error) => {
561+
if (error) {
562+
logWarningWhenErrorIsIgnored(triggerType, parseObject.className, auth, error);
563+
}
559564
logTriggerSuccessBeforeHook(
560565
triggerType,
561566
parseObject.className,

0 commit comments

Comments
 (0)