From 94f17623bc15fcd4a801e777dc6cc9aa701ae373 Mon Sep 17 00:00:00 2001 From: Manuel Trezza <5673677+mtrezza@users.noreply.github.com> Date: Fri, 9 Apr 2021 16:51:17 +0200 Subject: [PATCH 1/5] Add lock file version check to CI --- .github/workflows/ci.yml | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index c4c4c06faf..20ecc273f5 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -79,6 +79,14 @@ jobs: - uses: actions/checkout@v2 - name: Build docker image uses: docker/build-push-action@v2 + check-lock-file-version: + name: NPM Lock File Version + timeout-minutes: 5 + steps: + - uses: actions/checkout@v2 + - uses: mansona/npm-lockfile-version@v1 + with: + version: 1 check-mongo: strategy: matrix: From 8293510bd744867a6cd1a706e0483a78363a60b8 Mon Sep 17 00:00:00 2001 From: Manuel Trezza <5673677+mtrezza@users.noreply.github.com> Date: Fri, 9 Apr 2021 16:54:11 +0200 Subject: [PATCH 2/5] Update CHANGELOG.md --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index fd2b76864c..6e169866f2 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -128,6 +128,7 @@ ___ - Use Node.js 15.13.0 in CI (Olle Jonsson) [#7312](https://github.com/parse-community/parse-server/pull/7312) - Fix file upload issue for S3 compatible storage (Linode, DigitalOcean) by avoiding empty tags property when creating a file (Ali Oguzhan Yildiz) [#7300](https://github.com/parse-community/parse-server/pull/7300) - Add building Docker image as CI check (Manuel Trezza) [#7332](https://github.com/parse-community/parse-server/pull/7332) +- Add NPM package-lock version check to CI (Manuel Trezza) [#7333](https://github.com/parse-community/parse-server/pull/7333) ___ ## 4.5.0 [Full Changelog](https://github.com/parse-community/parse-server/compare/4.4.0...4.5.0) From 94cf85bafb12d2d4608f962a5d774c593e431e0b Mon Sep 17 00:00:00 2001 From: Manuel Trezza <5673677+mtrezza@users.noreply.github.com> Date: Fri, 9 Apr 2021 17:08:42 +0200 Subject: [PATCH 3/5] Update ci.yml --- .github/workflows/ci.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 20ecc273f5..5804224477 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -82,9 +82,11 @@ jobs: check-lock-file-version: name: NPM Lock File Version timeout-minutes: 5 + runs-on: ubuntu-18.04 steps: - uses: actions/checkout@v2 - - uses: mansona/npm-lockfile-version@v1 + - name: Check NPM lock file version + uses: mansona/npm-lockfile-version@v1 with: version: 1 check-mongo: From a5b4293f312942fea983e78c3c1ac4ee0690f9a5 Mon Sep 17 00:00:00 2001 From: Manuel Trezza <5673677+mtrezza@users.noreply.github.com> Date: Fri, 9 Apr 2021 17:10:38 +0200 Subject: [PATCH 4/5] test failing check with lock file version 2 --- package-lock.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package-lock.json b/package-lock.json index 0dd5c8acf6..8e4daa9d55 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,7 +1,7 @@ { "name": "parse-server", "version": "4.5.0", - "lockfileVersion": 1, + "lockfileVersion": 2, "requires": true, "dependencies": { "@actions/core": { From 1d63680894319c59522078743270716702fa102c Mon Sep 17 00:00:00 2001 From: Manuel Trezza <5673677+mtrezza@users.noreply.github.com> Date: Fri, 9 Apr 2021 17:11:22 +0200 Subject: [PATCH 5/5] Revert "test failing check with lock file version 2" This reverts commit a5b4293f312942fea983e78c3c1ac4ee0690f9a5. --- package-lock.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package-lock.json b/package-lock.json index 8e4daa9d55..0dd5c8acf6 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,7 +1,7 @@ { "name": "parse-server", "version": "4.5.0", - "lockfileVersion": 2, + "lockfileVersion": 1, "requires": true, "dependencies": { "@actions/core": {