diff --git a/package-lock.json b/package-lock.json index 0251984a35..5f38c25bb1 100644 --- a/package-lock.json +++ b/package-lock.json @@ -19,7 +19,7 @@ "@parse/push-adapter": "4.1.2", "bcryptjs": "2.4.3", "body-parser": "1.20.1", - "commander": "5.1.0", + "commander": "10.0.1", "cors": "2.8.5", "deepcopy": "2.1.0", "express": "4.18.2", @@ -5196,11 +5196,11 @@ } }, "node_modules/commander": { - "version": "5.1.0", - "resolved": "https://registry.npmjs.org/commander/-/commander-5.1.0.tgz", - "integrity": "sha512-P0CysNDQ7rtVw4QIQtm+MRxV66vKFSvlsQvGYXZWR3qFU0jlMKHZZZgw8e+8DSah4UDKMqnknRDQz+xuQXQ/Zg==", + "version": "10.0.1", + "resolved": "https://registry.npmjs.org/commander/-/commander-10.0.1.tgz", + "integrity": "sha512-y4Mg2tXshplEbSGzx7amzPwKKOCGuoSRP/CjEdwwk0FOGlUbq6lKuoyDZTNZkmxHdJtp54hdfY/JUrdL7Xfdug==", "engines": { - "node": ">= 6" + "node": ">=14" } }, "node_modules/commondir": { @@ -10426,6 +10426,15 @@ "integrity": "sha512-dOy+3AuW3a2wNbZHIuMZpTcgjGuLU/uBL/ubcZF9OXbDo8ff4O8yVp5Bf0efS8uEoYo5q4Fx7dY9OgQGXgAsQA==", "dev": true }, + "node_modules/lint-staged/node_modules/commander": { + "version": "5.1.0", + "resolved": "https://registry.npmjs.org/commander/-/commander-5.1.0.tgz", + "integrity": "sha512-P0CysNDQ7rtVw4QIQtm+MRxV66vKFSvlsQvGYXZWR3qFU0jlMKHZZZgw8e+8DSah4UDKMqnknRDQz+xuQXQ/Zg==", + "dev": true, + "engines": { + "node": ">= 6" + } + }, "node_modules/lint-staged/node_modules/cosmiconfig": { "version": "6.0.0", "resolved": "https://registry.npmjs.org/cosmiconfig/-/cosmiconfig-6.0.0.tgz", @@ -24462,9 +24471,9 @@ } }, "commander": { - "version": "5.1.0", - "resolved": "https://registry.npmjs.org/commander/-/commander-5.1.0.tgz", - "integrity": "sha512-P0CysNDQ7rtVw4QIQtm+MRxV66vKFSvlsQvGYXZWR3qFU0jlMKHZZZgw8e+8DSah4UDKMqnknRDQz+xuQXQ/Zg==" + "version": "10.0.1", + "resolved": "https://registry.npmjs.org/commander/-/commander-10.0.1.tgz", + "integrity": "sha512-y4Mg2tXshplEbSGzx7amzPwKKOCGuoSRP/CjEdwwk0FOGlUbq6lKuoyDZTNZkmxHdJtp54hdfY/JUrdL7Xfdug==" }, "commondir": { "version": "1.0.1", @@ -28521,6 +28530,12 @@ "integrity": "sha512-dOy+3AuW3a2wNbZHIuMZpTcgjGuLU/uBL/ubcZF9OXbDo8ff4O8yVp5Bf0efS8uEoYo5q4Fx7dY9OgQGXgAsQA==", "dev": true }, + "commander": { + "version": "5.1.0", + "resolved": "https://registry.npmjs.org/commander/-/commander-5.1.0.tgz", + "integrity": "sha512-P0CysNDQ7rtVw4QIQtm+MRxV66vKFSvlsQvGYXZWR3qFU0jlMKHZZZgw8e+8DSah4UDKMqnknRDQz+xuQXQ/Zg==", + "dev": true + }, "cosmiconfig": { "version": "6.0.0", "resolved": "https://registry.npmjs.org/cosmiconfig/-/cosmiconfig-6.0.0.tgz", diff --git a/package.json b/package.json index 127abee3eb..33727a9832 100644 --- a/package.json +++ b/package.json @@ -28,7 +28,7 @@ "@parse/push-adapter": "4.1.2", "bcryptjs": "2.4.3", "body-parser": "1.20.1", - "commander": "5.1.0", + "commander": "10.0.1", "cors": "2.8.5", "deepcopy": "2.1.0", "express": "4.18.2", diff --git a/spec/CLI.spec.js b/spec/CLI.spec.js index 9affc31016..20667fd349 100644 --- a/spec/CLI.spec.js +++ b/spec/CLI.spec.js @@ -74,7 +74,7 @@ describe('commander additions', () => { done(); }); - it('should load properly use args over env', done => { + it('should load properly use args over env', () => { commander.loadDefinitions(testDefinitions); commander.parse(['node', './CLI.spec.js', '--arg0', 'arg0Value', '--arg4', ''], { PROGRAM_ARG_0: 'arg0ENVValue', @@ -86,7 +86,6 @@ describe('commander additions', () => { expect(commander.arg1).toEqual('arg1ENVValue'); expect(commander.arg2).toEqual(4); expect(commander.arg4).toEqual(''); - done(); }); it('should fail in action as port is invalid', done => { diff --git a/src/cli/utils/commander.js b/src/cli/utils/commander.js index 8b8826fe69..75075bb3ac 100644 --- a/src/cli/utils/commander.js +++ b/src/cli/utils/commander.js @@ -136,5 +136,5 @@ Command.prototype.getOptions = function () { }, {}); }; -export default new Command(); +export default new Command().storeOptionsAsProperties(); /* eslint-enable no-console */