From 6181f614d1673f7a9481874a5f6f603ab0d766c5 Mon Sep 17 00:00:00 2001 From: snyk-bot Date: Sun, 21 May 2023 14:54:06 +0000 Subject: [PATCH 1/2] feat: upgrade commander from 5.1.0 to 10.0.1 Snyk has created this PR to upgrade commander from 5.1.0 to 10.0.1. See this package in npm: https://www.npmjs.com/package/commander See this project in Snyk: https://app.snyk.io/org/acinader/project/21343059-02d9-4182-87d7-718a44b181ef?utm_source=github&utm_medium=referral&page=upgrade-pr --- package-lock.json | 33 ++++++++++++++++++++++++--------- package.json | 2 +- 2 files changed, 25 insertions(+), 10 deletions(-) diff --git a/package-lock.json b/package-lock.json index 98435f92dc..25738571b9 100644 --- a/package-lock.json +++ b/package-lock.json @@ -19,7 +19,7 @@ "@parse/push-adapter": "4.1.2", "bcryptjs": "2.4.3", "body-parser": "1.20.1", - "commander": "5.1.0", + "commander": "^10.0.1", "cors": "2.8.5", "deepcopy": "2.1.0", "express": "4.18.2", @@ -75,7 +75,7 @@ "all-node-versions": "11.3.0", "apollo-upload-client": "17.0.0", "bcrypt-nodejs": "0.0.3", - "clean-jsdoc-theme": "^4.2.7", + "clean-jsdoc-theme": "4.2.7", "cross-env": "7.0.2", "deep-diff": "1.0.2", "eslint": "8.26.0", @@ -5173,11 +5173,11 @@ } }, "node_modules/commander": { - "version": "5.1.0", - "resolved": "https://registry.npmjs.org/commander/-/commander-5.1.0.tgz", - "integrity": "sha512-P0CysNDQ7rtVw4QIQtm+MRxV66vKFSvlsQvGYXZWR3qFU0jlMKHZZZgw8e+8DSah4UDKMqnknRDQz+xuQXQ/Zg==", + "version": "10.0.1", + "resolved": "https://registry.npmjs.org/commander/-/commander-10.0.1.tgz", + "integrity": "sha512-y4Mg2tXshplEbSGzx7amzPwKKOCGuoSRP/CjEdwwk0FOGlUbq6lKuoyDZTNZkmxHdJtp54hdfY/JUrdL7Xfdug==", "engines": { - "node": ">= 6" + "node": ">=14" } }, "node_modules/commondir": { @@ -10398,6 +10398,15 @@ "integrity": "sha512-dOy+3AuW3a2wNbZHIuMZpTcgjGuLU/uBL/ubcZF9OXbDo8ff4O8yVp5Bf0efS8uEoYo5q4Fx7dY9OgQGXgAsQA==", "dev": true }, + "node_modules/lint-staged/node_modules/commander": { + "version": "5.1.0", + "resolved": "https://registry.npmjs.org/commander/-/commander-5.1.0.tgz", + "integrity": "sha512-P0CysNDQ7rtVw4QIQtm+MRxV66vKFSvlsQvGYXZWR3qFU0jlMKHZZZgw8e+8DSah4UDKMqnknRDQz+xuQXQ/Zg==", + "dev": true, + "engines": { + "node": ">= 6" + } + }, "node_modules/lint-staged/node_modules/cosmiconfig": { "version": "6.0.0", "resolved": "https://registry.npmjs.org/cosmiconfig/-/cosmiconfig-6.0.0.tgz", @@ -24432,9 +24441,9 @@ } }, "commander": { - "version": "5.1.0", - "resolved": "https://registry.npmjs.org/commander/-/commander-5.1.0.tgz", - "integrity": "sha512-P0CysNDQ7rtVw4QIQtm+MRxV66vKFSvlsQvGYXZWR3qFU0jlMKHZZZgw8e+8DSah4UDKMqnknRDQz+xuQXQ/Zg==" + "version": "10.0.1", + "resolved": "https://registry.npmjs.org/commander/-/commander-10.0.1.tgz", + "integrity": "sha512-y4Mg2tXshplEbSGzx7amzPwKKOCGuoSRP/CjEdwwk0FOGlUbq6lKuoyDZTNZkmxHdJtp54hdfY/JUrdL7Xfdug==" }, "commondir": { "version": "1.0.1", @@ -28486,6 +28495,12 @@ "integrity": "sha512-dOy+3AuW3a2wNbZHIuMZpTcgjGuLU/uBL/ubcZF9OXbDo8ff4O8yVp5Bf0efS8uEoYo5q4Fx7dY9OgQGXgAsQA==", "dev": true }, + "commander": { + "version": "5.1.0", + "resolved": "https://registry.npmjs.org/commander/-/commander-5.1.0.tgz", + "integrity": "sha512-P0CysNDQ7rtVw4QIQtm+MRxV66vKFSvlsQvGYXZWR3qFU0jlMKHZZZgw8e+8DSah4UDKMqnknRDQz+xuQXQ/Zg==", + "dev": true + }, "cosmiconfig": { "version": "6.0.0", "resolved": "https://registry.npmjs.org/cosmiconfig/-/cosmiconfig-6.0.0.tgz", diff --git a/package.json b/package.json index 8a0338e441..b777f1e899 100644 --- a/package.json +++ b/package.json @@ -28,7 +28,7 @@ "@parse/push-adapter": "4.1.2", "bcryptjs": "2.4.3", "body-parser": "1.20.1", - "commander": "5.1.0", + "commander": "10.0.1", "cors": "2.8.5", "deepcopy": "2.1.0", "express": "4.18.2", From 9f1d05be259429a9ca8c1fe2fcb1a08b7c83366f Mon Sep 17 00:00:00 2001 From: dblythy Date: Mon, 22 May 2023 14:27:24 +1000 Subject: [PATCH 2/2] refactor: Upgrade commander from 5.1.0 to 10.0.1 --- package-lock.json | 2 +- spec/CLI.spec.js | 3 +-- src/cli/utils/commander.js | 2 +- 3 files changed, 3 insertions(+), 4 deletions(-) diff --git a/package-lock.json b/package-lock.json index 25738571b9..e353701572 100644 --- a/package-lock.json +++ b/package-lock.json @@ -19,7 +19,7 @@ "@parse/push-adapter": "4.1.2", "bcryptjs": "2.4.3", "body-parser": "1.20.1", - "commander": "^10.0.1", + "commander": "10.0.1", "cors": "2.8.5", "deepcopy": "2.1.0", "express": "4.18.2", diff --git a/spec/CLI.spec.js b/spec/CLI.spec.js index 9affc31016..20667fd349 100644 --- a/spec/CLI.spec.js +++ b/spec/CLI.spec.js @@ -74,7 +74,7 @@ describe('commander additions', () => { done(); }); - it('should load properly use args over env', done => { + it('should load properly use args over env', () => { commander.loadDefinitions(testDefinitions); commander.parse(['node', './CLI.spec.js', '--arg0', 'arg0Value', '--arg4', ''], { PROGRAM_ARG_0: 'arg0ENVValue', @@ -86,7 +86,6 @@ describe('commander additions', () => { expect(commander.arg1).toEqual('arg1ENVValue'); expect(commander.arg2).toEqual(4); expect(commander.arg4).toEqual(''); - done(); }); it('should fail in action as port is invalid', done => { diff --git a/src/cli/utils/commander.js b/src/cli/utils/commander.js index 8b8826fe69..75075bb3ac 100644 --- a/src/cli/utils/commander.js +++ b/src/cli/utils/commander.js @@ -136,5 +136,5 @@ Command.prototype.getOptions = function () { }, {}); }; -export default new Command(); +export default new Command().storeOptionsAsProperties(); /* eslint-enable no-console */