From ff50a0d150ab9fbba0ec55aa84417079962e2c3b Mon Sep 17 00:00:00 2001 From: dblythy Date: Fri, 30 Jun 2023 13:49:58 +1000 Subject: [PATCH 1/2] feat: add `security.enableCheck` status to FeaturesRouter --- spec/SecurityCheck.spec.js | 28 ++++++++++++++++++++++++++++ src/Routers/FeaturesRouter.js | 3 +++ 2 files changed, 31 insertions(+) diff --git a/spec/SecurityCheck.spec.js b/spec/SecurityCheck.spec.js index 647ed909c0..16bd231b64 100644 --- a/spec/SecurityCheck.spec.js +++ b/spec/SecurityCheck.spec.js @@ -337,5 +337,33 @@ describe('Security Check', () => { expect(logSpy.calls.all()[0].args[0]).toContain(title); } }); + + it('does update featuresRouter', async () => { + let response = await request({ + url: 'http://localhost:8378/1/serverInfo', + json: true, + headers: { + 'X-Parse-Application-Id': 'test', + 'X-Parse-REST-API-Key': 'rest', + 'X-Parse-Master-Key': 'test', + }, + }); + expect(response.data.features.settings.security).toBeTrue(); + await reconfigureServer({ + security: { + enableCheck: false, + }, + }); + response = await request({ + url: 'http://localhost:8378/1/serverInfo', + json: true, + headers: { + 'X-Parse-Application-Id': 'test', + 'X-Parse-REST-API-Key': 'rest', + 'X-Parse-Master-Key': 'test', + }, + }); + expect(response.data.features.settings.security).toBeFalse(); + }); }); }); diff --git a/src/Routers/FeaturesRouter.js b/src/Routers/FeaturesRouter.js index 649cefcb3a..4c16b76a1a 100644 --- a/src/Routers/FeaturesRouter.js +++ b/src/Routers/FeaturesRouter.js @@ -46,6 +46,9 @@ export class FeaturesRouter extends PromiseRouter { editClassLevelPermissions: true, editPointerPermissions: true, }, + settings: { + security: !!config.security?.enableCheck, + }, }; return { From 122ff27d5fef3da278d1a043f86ac2120d736f6f Mon Sep 17 00:00:00 2001 From: Manuel <5673677+mtrezza@users.noreply.github.com> Date: Sun, 24 Mar 2024 00:23:41 +0100 Subject: [PATCH 2/2] rename feature setting Signed-off-by: Manuel <5673677+mtrezza@users.noreply.github.com> --- spec/SecurityCheck.spec.js | 4 ++-- src/Routers/FeaturesRouter.js | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/spec/SecurityCheck.spec.js b/spec/SecurityCheck.spec.js index 16bd231b64..6c61bbf90b 100644 --- a/spec/SecurityCheck.spec.js +++ b/spec/SecurityCheck.spec.js @@ -348,7 +348,7 @@ describe('Security Check', () => { 'X-Parse-Master-Key': 'test', }, }); - expect(response.data.features.settings.security).toBeTrue(); + expect(response.data.features.settings.securityCheck).toBeTrue(); await reconfigureServer({ security: { enableCheck: false, @@ -363,7 +363,7 @@ describe('Security Check', () => { 'X-Parse-Master-Key': 'test', }, }); - expect(response.data.features.settings.security).toBeFalse(); + expect(response.data.features.settings.securityCheck).toBeFalse(); }); }); }); diff --git a/src/Routers/FeaturesRouter.js b/src/Routers/FeaturesRouter.js index 4c16b76a1a..df26338955 100644 --- a/src/Routers/FeaturesRouter.js +++ b/src/Routers/FeaturesRouter.js @@ -47,7 +47,7 @@ export class FeaturesRouter extends PromiseRouter { editPointerPermissions: true, }, settings: { - security: !!config.security?.enableCheck, + securityCheck: !!config.security?.enableCheck, }, };