Skip to content

Commit 39d5dd4

Browse files
authored
Dedup install mkl (pytorch#455)
* Extract MKL version and build number into env vars * Use common/install_mkl.sh to install MKL * Rectify duplicate "Install MKL" step from libtorch/ubuntu16.04/Dockerfile
1 parent 11c8670 commit 39d5dd4

File tree

3 files changed

+9
-18
lines changed

3 files changed

+9
-18
lines changed

common/install_mkl.sh

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,11 @@
33
set -ex
44

55
# MKL
6+
MKL_VERSION=2019.5
7+
MKL_BUILD=281
68
mkdir -p /opt/intel/lib
79
pushd /tmp
8-
curl -fsSL https://anaconda.org/intel/mkl-static/2019.5/download/linux-64/mkl-static-2019.5-intel_281.tar.bz2 | tar xjv
10+
curl -fsSL https://anaconda.org/intel/mkl-static/${MKL_VERSION}/download/linux-64/mkl-static-${MKL_VERSION}-intel_${MKL_BUILD}.tar.bz2 | tar xjv
911
mv lib/* /opt/intel/lib/
10-
curl -fsSL https://anaconda.org/intel/mkl-include/2019.5/download/linux-64/mkl-include-2019.5-intel_281.tar.bz2 | tar xjv
12+
curl -fsSL https://anaconda.org/intel/mkl-include/${MKL_VERSION}/download/linux-64/mkl-include-${MKL_VERSION}-intel_${MKL_BUILD}.tar.bz2 | tar xjv
1113
mv include /opt/intel/

libtorch/ubuntu16.04/Dockerfile

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -10,12 +10,9 @@ ENV LANG en_US.UTF-8
1010
ENV LANGUAGE en_US.UTF-8
1111

1212
FROM base as intel
13-
RUN mkdir -p /opt/intel/lib
14-
WORKDIR /tmp
15-
RUN curl -fsSL https://anaconda.org/intel/mkl-static/2019.5/download/linux-64/mkl-static-2019.5-intel_281.tar.bz2 | tar xjv
16-
RUN mv lib/* /opt/intel/lib/
17-
RUN curl -fsSL https://anaconda.org/intel/mkl-include/2019.5/download/linux-64/mkl-include-2019.5-intel_281.tar.bz2 | tar xjv
18-
RUN mv include /opt/intel/
13+
# Install MKL
14+
ADD ./common/install_mkl.sh install_mkl.sh
15+
RUN bash ./install_mkl.sh && rm install_mkl.sh
1916

2017
FROM base as cuda
2118
ADD ./common/install_cuda.sh install_cuda.sh
@@ -37,10 +34,6 @@ FROM base as final
3734
ADD ./common/install_patchelf.sh install_patchelf.sh
3835
RUN bash ./install_patchelf.sh && rm install_patchelf.sh
3936

40-
# Install MKL
41-
ADD ./common/install_mkl.sh install_mkl.sh
42-
RUN bash ./install_mkl.sh && rm install_mkl.sh
43-
4437
# Install MAGMA (need CUDA)
4538
ADD ./common/install_magma.sh install_magma.sh
4639
RUN bash ./install_magma.sh 9.2 10.0 10.1 10.2 && rm install_magma.sh

manywheel/Dockerfile

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -42,12 +42,8 @@ RUN bash ./install_cuda.sh ${BASE_CUDA_VERSION} && rm install_cuda.sh
4242

4343
FROM base as intel
4444
# MKL
45-
RUN mkdir -p /opt/intel/lib
46-
WORKDIR /tmp
47-
RUN curl -fsSL https://anaconda.org/intel/mkl-static/2019.5/download/linux-64/mkl-static-2019.5-intel_281.tar.bz2 | tar xjv
48-
RUN mv lib/* /opt/intel/lib/
49-
RUN curl -fsSL https://anaconda.org/intel/mkl-include/2019.5/download/linux-64/mkl-include-2019.5-intel_281.tar.bz2 | tar xjv
50-
RUN mv include /opt/intel/
45+
ADD ./common/install_mkl.sh install_mkl.sh
46+
RUN bash ./install_mkl.sh && rm install_mkl.sh
5147

5248
# EPEL for cmake
5349
FROM base as patchelf

0 commit comments

Comments
 (0)