Skip to content

add tests for read_table, read_fwf, read_excel #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

MarcoGorelli
Copy link

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@MarcoGorelli MarcoGorelli force-pushed the pr/phofl/read_csv_date_format branch from a26e6c6 to 96d93d7 Compare February 16, 2023 10:32
@MarcoGorelli MarcoGorelli force-pushed the pr/phofl/read_csv_date_format branch from 96d93d7 to fdea2cc Compare February 16, 2023 12:27
date_format : str or dict of column -> format default None
date_format : str, default None
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one was the excel writer, not the reader, which we're not changing here

date_f = (
date_fmt = (
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

renaming as date_f making it sound like "date function" to me

@MarcoGorelli MarcoGorelli force-pushed the pr/phofl/read_csv_date_format branch from fdea2cc to 7866839 Compare February 16, 2023 12:41
@MarcoGorelli MarcoGorelli marked this pull request as ready for review February 16, 2023 12:42
@MarcoGorelli MarcoGorelli merged commit 7866839 into phofl:read_csv_date_format Feb 16, 2023
phofl pushed a commit that referenced this pull request Mar 7, 2023
* Removed PLR5501

* 7 elif changed

* 8 more

* more fixess

* moreeeeeeeee changes

* fix python_parser.py (try #1)

* try no. 2

* fix python_parser.py (try no. 3)

* v2.1.0 (fix try 1)

* try no. 2

* Removed extra lines
jorisvandenbossche pushed a commit that referenced this pull request Oct 28, 2024
* second item in tuple is no longer truncated at first colon

pandas-dev#59623

* added testcase for maybe_convert_css_to_tuples

pandas-dev#59623

* maybe_convert_css_to_tuples() raises on strings without ":"

* fixed implicit str concatination

* Fixed raise on empty string

* Update test_style.py

* attr:; -> ("attr","")

Same behavior as before patch

* add test for "attr:;", ie empty value

* str concatenation in the test broke mypy

* revert explicit str concat

* Invalidarg patch black (#1)

* black test_style

* Update style_render.py

---------

Co-authored-by: Matthew Roeschke <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant