make classes final

Author: dbu

CHANGELOG.md

@@ -5,6 +5,7 @@ The change log describes what is "Added", "Removed", "Changed" or "Fixed" betwee
 # Version 2
 
 # 2.0.0 - (unreleased)
+
 - Increased min PHP version to 8.1
 - Removed the deprecated `Http\HttplugBundle\ClientFactory\PluginClientFactory`. Use `Http\Client\Common\PluginClientFactory` instead.
 - Fixed a deprecation when creating a `HttpMethodsClient` via `http_methods_client: true`. Only PSR-17 factories are now passed as constructor arguments.
@@ -18,6 +19,7 @@ The change log describes what is "Added", "Removed", "Changed" or "Fixed" betwee
 - Changed the type of `httplug.client.default` to `ClientInterface` instead of `HttpClient`
 - Removed the `DummyClient` interface
 - Removed the `Http\Client\HttpClient` alias use the `Psr\Http\Client\ClientInterface` typehint in your services for autowiring.
+- Changed classes marked as `@final` to be actually `final`. If you extended any of those, instead implement interfaces or decorate the class rather than extending it. Open an issue if you think a class needs to be made non-final to discuss what we should do.
 
 # Version 1
 

src/ClientFactory/AutoDiscoveryFactory.php

@@ -10,10 +10,8 @@
  * Use auto discovery to find a HTTP client.
  *
  * @author Tobias Nyholm <[email protected]>
- *
- * @final
  */
-class AutoDiscoveryFactory implements ClientFactory
+final class AutoDiscoveryFactory implements ClientFactory
 {
     public function createClient(array $config = [])
     {

src/ClientFactory/BuzzFactory.php

@@ -10,10 +10,8 @@
 
 /**
  * @author Tobias Nyholm <[email protected]>
- *
- * @final
  */
-class BuzzFactory implements ClientFactory
+final class BuzzFactory implements ClientFactory
 {
     public function __construct(private readonly ResponseFactoryInterface $responseFactory)
     {

src/ClientFactory/CurlFactory.php

@@ -10,10 +10,8 @@
 
 /**
  * @author Tobias Nyholm <[email protected]>
- *
- * @final
  */
-class CurlFactory implements ClientFactory
+final class CurlFactory implements ClientFactory
 {
     public function __construct(
         private readonly ResponseFactoryInterface $responseFactory,

src/ClientFactory/Guzzle6Factory.php

@@ -8,10 +8,8 @@
 
 /**
  * @author Tobias Nyholm <[email protected]>
- *
- * @final
  */
-class Guzzle6Factory implements ClientFactory
+final class Guzzle6Factory implements ClientFactory
 {
     public function createClient(array $config = [])
     {

src/ClientFactory/Guzzle7Factory.php

@@ -8,10 +8,8 @@
 
 /**
  * @author Tobias Nyholm <[email protected]>
- *
- * @final
  */
-class Guzzle7Factory implements ClientFactory
+final class Guzzle7Factory implements ClientFactory
 {
     public function createClient(array $config = [])
     {

src/ClientFactory/ReactFactory.php

@@ -8,10 +8,8 @@
 
 /**
  * @author Tobias Nyholm <[email protected]>
- *
- * @final
  */
-class ReactFactory implements ClientFactory
+final class ReactFactory implements ClientFactory
 {
     public function createClient(array $config = [])
     {

src/ClientFactory/SocketFactory.php

@@ -8,10 +8,8 @@
 
 /**
  * @author Tobias Nyholm <[email protected]>
- *
- * @final
  */
-class SocketFactory implements ClientFactory
+final class SocketFactory implements ClientFactory
 {
     public function createClient(array $config = [])
     {

src/ClientFactory/SymfonyFactory.php

@@ -11,10 +11,8 @@
 
 /**
  * @author Tobias Nyholm <[email protected]>
- *
- * @final
  */
-class SymfonyFactory implements ClientFactory
+final class SymfonyFactory implements ClientFactory
 {
     public function __construct(
         private readonly ResponseFactoryInterface $responseFactory,

src/Collector/Collector.php

@@ -18,10 +18,8 @@
  * @author Fabien Bourigault <[email protected]>
  *
  * @internal
- *
- * @final
  */
-class Collector extends DataCollector
+final class Collector extends DataCollector
 {
     private ?Stack $activeStack = null;