Skip to content

Commit 51144d8

Browse files
committed
Make plugin classes final, related #18
1 parent 52b23ee commit 51144d8

14 files changed

+15
-57
lines changed

src/Plugin/AddHostPlugin.php

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,10 +11,8 @@
1111
* Add schema and host to a request. Can be set to overwrite the schema and host if desired.
1212
*
1313
* @author Tobias Nyholm <[email protected]>
14-
*
15-
* TODO: make class final in version 2.0, once plugins does not extend it anymore.
1614
*/
17-
/*final*/ class AddHostPlugin implements Plugin
15+
final class AddHostPlugin implements Plugin
1816
{
1917
/**
2018
* @var UriInterface

src/Plugin/AuthenticationPlugin.php

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,8 @@
1010
* Send an authenticated request.
1111
*
1212
* @author Joel Wurtz <[email protected]>
13-
*
14-
* TODO: make class final in version 2.0, once plugins does not extend it anymore.
1513
*/
16-
/*final*/ class AuthenticationPlugin implements Plugin
14+
final class AuthenticationPlugin implements Plugin
1715
{
1816
/**
1917
* @var Authentication An authentication system

src/Plugin/ContentLengthPlugin.php

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,8 @@
1010
* Allow to set the correct content length header on the request or to transfer it as a chunk if not possible.
1111
*
1212
* @author Joel Wurtz <[email protected]>
13-
*
14-
* TODO: make class final in version 2.0, once plugins does not extend it anymore.
1513
*/
16-
/*final*/ class ContentLengthPlugin implements Plugin
14+
final class ContentLengthPlugin implements Plugin
1715
{
1816
/**
1917
* {@inheritdoc}

src/Plugin/CookiePlugin.php

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,8 @@
1212
* Handle request cookies.
1313
*
1414
* @author Joel Wurtz <[email protected]>
15-
*
16-
* TODO: make class final in version 2.0, once plugins does not extend it anymore.
1715
*/
18-
/*final*/ class CookiePlugin implements Plugin
16+
final class CookiePlugin implements Plugin
1917
{
2018
/**
2119
* Cookie storage.

src/Plugin/DecoderPlugin.php

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,10 +17,8 @@
1717
* If Content-Encoding is not disabled, the plugin will add an Accept-Encoding header for the encoding methods it supports.
1818
*
1919
* @author Joel Wurtz <[email protected]>
20-
*
21-
* TODO: make class final in version 2.0, once plugins does not extend it anymore.
2220
*/
23-
/*final*/ class DecoderPlugin implements Plugin
21+
final class DecoderPlugin implements Plugin
2422
{
2523
/**
2624
* @var bool Whether this plugin decode stream with value in the Content-Encoding header (default to true).

src/Plugin/ErrorPlugin.php

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,8 @@
1414
* By default an exception will be thrown for all status codes from 400 to 599.
1515
*
1616
* @author Joel Wurtz <[email protected]>
17-
*
18-
* TODO: make class final in version 2.0, once plugins does not extend it anymore.
1917
*/
20-
/*final*/ class ErrorPlugin implements Plugin
18+
final class ErrorPlugin implements Plugin
2119
{
2220
/**
2321
* {@inheritdoc}

src/Plugin/HeaderAppendPlugin.php

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,8 @@
1414
* @link https://en.wikipedia.org/wiki/List_of_HTTP_header_fields
1515
*
1616
* @author Soufiane Ghzal <[email protected]>
17-
*
18-
* TODO: make class final in version 2.0, once plugins does not extend it anymore.
1917
*/
20-
/*final*/ class HeaderAppendPlugin implements Plugin
18+
final class HeaderAppendPlugin implements Plugin
2119
{
2220
/**
2321
* @var array

src/Plugin/HeaderDefaultsPlugin.php

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,8 @@
1010
* If a given header already exists the value wont be replaced and the request wont be changed.
1111
*
1212
* @author Soufiane Ghzal <[email protected]>
13-
*
14-
* TODO: make class final in version 2.0, once plugins does not extend it anymore.
1513
*/
16-
/*final*/ class HeaderDefaultsPlugin implements Plugin
14+
final class HeaderDefaultsPlugin implements Plugin
1715
{
1816
/**
1917
* @var array

src/Plugin/HeaderRemovePlugin.php

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,8 @@
99
* Removes headers from the request.
1010
*
1111
* @author Soufiane Ghzal <[email protected]>
12-
*
13-
* TODO: make class final in version 2.0, once plugins does not extend it anymore.
1412
*/
15-
/*final*/ class HeaderRemovePlugin implements Plugin
13+
final class HeaderRemovePlugin implements Plugin
1614
{
1715
/**
1816
* @var array

src/Plugin/HeaderSetPlugin.php

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,8 @@
1010
* If the header does not exist it wil be set, if the header already exists it will be replaced.
1111
*
1212
* @author Soufiane Ghzal <[email protected]>
13-
*
14-
* TODO: make class final in version 2.0, once plugins does not extend it anymore.
1513
*/
16-
/*final*/ class HeaderSetPlugin implements Plugin
14+
final class HeaderSetPlugin implements Plugin
1715
{
1816
/**
1917
* @var array

0 commit comments

Comments
 (0)