From e3cdeef6428a6efa2c37ceaed232a0e3d2e1e1c5 Mon Sep 17 00:00:00 2001 From: Niklas Keller Date: Mon, 10 Jul 2017 17:21:50 +0200 Subject: [PATCH 1/2] Sending Content-Length: 0 is optional for TRACE --- src/HttpBaseTest.php | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/HttpBaseTest.php b/src/HttpBaseTest.php index 72bcf62..e6d1bef 100644 --- a/src/HttpBaseTest.php +++ b/src/HttpBaseTest.php @@ -270,6 +270,10 @@ protected function assertRequest( $name = strtoupper(str_replace('-', '_', 'http-'.$name)); + if ($method === 'TRACE' && $name === 'HTTP_CONTENT_LENGTH' && !isset($request['SERVER'][$name])) { + $request['SERVER'][$name] = '0'; + } + $this->assertArrayHasKey($name, $request['SERVER']); $this->assertSame($value, $request['SERVER'][$name], "Failed asserting value for {$name}."); } From 2c6dca9425f4cbcbf009310d5149d57446488cbe Mon Sep 17 00:00:00 2001 From: Niklas Keller Date: Mon, 10 Jul 2017 17:48:58 +0200 Subject: [PATCH 2/2] Don't make any useless assertions --- src/HttpBaseTest.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/HttpBaseTest.php b/src/HttpBaseTest.php index e6d1bef..2c4a993 100644 --- a/src/HttpBaseTest.php +++ b/src/HttpBaseTest.php @@ -271,7 +271,7 @@ protected function assertRequest( $name = strtoupper(str_replace('-', '_', 'http-'.$name)); if ($method === 'TRACE' && $name === 'HTTP_CONTENT_LENGTH' && !isset($request['SERVER'][$name])) { - $request['SERVER'][$name] = '0'; + continue; } $this->assertArrayHasKey($name, $request['SERVER']);