adjust BatchResult to interface cleanup #12
Conversation
|
tests will fail until php-http/httplug#73 is merged. |
| try { | ||
| return $this->exceptions[$request]; | ||
| } catch (\UnexpectedValueException $e) { | ||
| throw new UnexpectedValueException('Request not found', $e->getCode(), $e); |
There was a problem hiding this comment.
Isn't this exception an SPL UnexpectedException as well?
There was a problem hiding this comment.
(i only reordered this method, did not change any content)
seems to be the same yes. but the exception message will become more specific like this, which seems to be worth it.
There was a problem hiding this comment.
I think I did this rethrow thing in order to hide the original Object not found message. But the question is: If it is the same, why isn't it used from the root namespace as well?
There was a problem hiding this comment.
we have a use UnexpectedValueException in this file. probably against conventions, i can remove it and use \UnexpectedValueException everywhere. ok?
dbu
force-pushed
the
adjust-batchresult
branch
from
68986c7 to
1c6d0e1
Compare
adjust BatchResult to interface cleanup
depends on php-http/httplug#73