Skip to content

Commit 6f9ce34

Browse files
tkaratugCodeWithKyrian
authored andcommitted
refactor: Update handler assertions in ManualRegistrationTest
- Changed assertions in ManualRegistrationTest to verify handler as an array containing the handler class and method instead of separate properties. - Updated tests to reflect the new structure for handler registration, ensuring consistency across tool, resource, and prompt registrations.
1 parent f76a6f6 commit 6f9ce34

File tree

1 file changed

+5
-10
lines changed

1 file changed

+5
-10
lines changed

tests/Feature/ManualRegistrationTest.php

Lines changed: 5 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,7 @@ public function test_can_manually_register_a_tool()
3131
$this->assertInstanceOf(RegisteredTool::class, $tool);
3232
$this->assertEquals('manual_test_tool', $tool->schema->name);
3333
$this->assertEquals('A manually registered test tool.', $tool->schema->description);
34-
$this->assertEquals(ManualTestHandler::class, $tool->handlerClass);
35-
$this->assertEquals('handleTool', $tool->handlerMethod);
34+
$this->assertEquals([ManualTestHandler::class, 'handleTool'], $tool->handler);
3635
$this->assertArrayHasKey('input', $tool->schema->inputSchema['properties']);
3736
$this->assertEquals('string', $tool->schema->inputSchema['properties']['input']['type']);
3837
}
@@ -52,8 +51,7 @@ public function test_can_manually_register_tool_using_handler_only()
5251
$tool = $registry->getTool('handleTool');
5352

5453
$this->assertNotNull($tool);
55-
$this->assertEquals(ManualTestHandler::class, $tool->handlerClass);
56-
$this->assertEquals('handleTool', $tool->handlerMethod);
54+
$this->assertEquals([ManualTestHandler::class, 'handleTool'], $tool->handler);
5755
$this->assertEquals('A sample tool handler.', $tool->schema->description);
5856
}
5957

@@ -82,8 +80,7 @@ public function test_can_manually_register_a_resource()
8280
$this->assertEquals('application/json', $resource->schema->mimeType);
8381
$this->assertEquals(1024, $resource->schema->size);
8482
$this->assertEquals(['priority' => 0.8], $resource->schema->annotations->toArray());
85-
$this->assertEquals(ManualTestHandler::class, $resource->handlerClass);
86-
$this->assertEquals('handleResource', $resource->handlerMethod);
83+
$this->assertEquals([ManualTestHandler::class, 'handleResource'], $resource->handler);
8784
}
8885

8986
public function test_can_manually_register_a_prompt_with_invokable_class_handler()
@@ -104,8 +101,7 @@ public function test_can_manually_register_a_prompt_with_invokable_class_handler
104101
$this->assertInstanceOf(RegisteredPrompt::class, $prompt);
105102
$this->assertEquals('manual_invokable_prompt', $prompt->schema->name);
106103
$this->assertEquals('A prompt handled by an invokable class.', $prompt->schema->description);
107-
$this->assertEquals(ManualTestInvokableHandler::class, $prompt->handlerClass);
108-
$this->assertEquals('__invoke', $prompt->handlerMethod);
104+
$this->assertEquals(ManualTestInvokableHandler::class, $prompt->handler);
109105
}
110106

111107
public function test_can_manually_register_a_resource_template_via_facade()
@@ -130,7 +126,6 @@ public function test_can_manually_register_a_resource_template_via_facade()
130126
$this->assertEquals('manual_item_details_template', $template->schema->name);
131127
$this->assertEquals('A sample resource template handler.', $template->schema->description);
132128
$this->assertEquals('application/vnd.api+json', $template->schema->mimeType);
133-
$this->assertEquals(ManualTestHandler::class, $template->handlerClass);
134-
$this->assertEquals('handleTemplate', $template->handlerMethod);
129+
$this->assertEquals([ManualTestHandler::class, 'handleTemplate'], $template->handler);
135130
}
136131
}

0 commit comments

Comments
 (0)