From 8a56321487a034989fe32776b5b9fd051b023bc6 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Tim=20D=C3=BCsterhus?= <tim@tideways-gmbh.com>
Date: Tue, 22 Oct 2024 14:50:41 +0200
Subject: [PATCH 1/2] Document `ReflectionGenerator::isClosed()`

---
 .../reflectiongenerator/isclosed.xml          | 94 +++++++++++++++++++
 reference/reflection/versions.xml             |  1 +
 2 files changed, 95 insertions(+)
 create mode 100644 reference/reflection/reflectiongenerator/isclosed.xml

diff --git a/reference/reflection/reflectiongenerator/isclosed.xml b/reference/reflection/reflectiongenerator/isclosed.xml
new file mode 100644
index 000000000000..69a08faeb5b3
--- /dev/null
+++ b/reference/reflection/reflectiongenerator/isclosed.xml
@@ -0,0 +1,94 @@
+<?xml version="1.0" encoding="utf-8"?>
+<!-- $Revision$ -->
+<refentry xml:id="reflectiongenerator.isclosed" xmlns="http://docbook.org/ns/docbook" xmlns:xlink="http://www.w3.org/1999/xlink">
+ <refnamediv>
+  <refname>ReflectionGenerator::isClosed</refname>
+  <refpurpose>Checks if execution finished</refpurpose>
+ </refnamediv>
+
+ <refsect1 role="description">
+  &reftitle.description;
+  <methodsynopsis role="ReflectionGenerator">
+   <modifier>public</modifier> <type>bool</type><methodname>ReflectionGenerator::isClosed</methodname>
+   <void/>
+  </methodsynopsis>
+  <para>
+   Returns whether the execution reached the end of the function, a return statement or if an exception was thrown.
+  </para>
+ </refsect1>
+
+ <refsect1 role="parameters">
+  &reftitle.parameters;
+  &no.function.parameters;
+ </refsect1>
+
+ <refsect1 role="returnvalues">
+  &reftitle.returnvalues;
+  <para>
+   Returns whether the generator finished executing.
+  </para>
+ </refsect1>
+
+  <refsect1 role="examples">
+  &reftitle.examples;
+  <para>
+   <example>
+    <title><methodname>ReflectionGenerator::isClosed</methodname> example</title>
+    <programlisting role="php">
+<![CDATA[
+<?php
+
+function gen()
+{
+    yield 'a';
+    yield 'a';
+}
+
+$gen = gen();
+$reflectionGen = new ReflectionGenerator($gen);
+
+foreach ($gen as $value) {
+    echo $value, PHP_EOL;
+    var_dump($reflectionGen->isClosed());
+}
+
+var_dump($reflectionGen->isClosed());
+
+?>
+]]>
+    </programlisting>
+    &example.outputs;
+    <screen>
+<![CDATA[
+a
+bool(false)
+a
+bool(false)
+bool(true)
+]]>
+    </screen>
+   </example>
+  </para>
+ </refsect1>
+
+</refentry>
+<!-- Keep this comment at the end of the file
+Local variables:
+mode: sgml
+sgml-omittag:t
+sgml-shorttag:t
+sgml-minimize-attributes:nil
+sgml-always-quote-attributes:t
+sgml-indent-step:1
+sgml-indent-data:t
+indent-tabs-mode:nil
+sgml-parent-document:nil
+sgml-default-dtd-file:"~/.phpdoc/manual.ced"
+sgml-exposed-tags:nil
+sgml-local-catalogs:nil
+sgml-local-ecat-files:nil
+End:
+vim600: syn=xml fen fdm=syntax fdl=2 si
+vim: et tw=78 syn=sgml
+vi: ts=1 sw=1
+-->
diff --git a/reference/reflection/versions.xml b/reference/reflection/versions.xml
index c9306527d28e..a868b02e448b 100644
--- a/reference/reflection/versions.xml
+++ b/reference/reflection/versions.xml
@@ -375,6 +375,7 @@
  <function name="reflectiongenerator::getexecutingline" from="PHP 7, PHP 8"/>
  <function name="reflectiongenerator::getexecutingfile" from="PHP 7, PHP 8"/>
  <function name="reflectiongenerator::getexecutinggenerator" from="PHP 7, PHP 8"/>
+ <function name="reflectiongenerator::isclosed" from="PHP 8 &gt;= 8.4.0"/>
 
  <function name="reflectionreference" from="PHP 7 &gt;= 7.4.0, PHP 8"/>
  <function name="reflectionreference::fromarrayelement" from="PHP 7 &gt;= 7.4.0, PHP 8"/>

From 86f0f3f9c6e1b437e67abe56644bc4309db4485f Mon Sep 17 00:00:00 2001
From: Gina Peter Banyard <girgias@php.net>
Date: Tue, 22 Oct 2024 15:25:35 +0100
Subject: [PATCH 2/2] Fix some markup issues

---
 .../reflectiongenerator/isclosed.xml          | 26 +++++++++----------
 1 file changed, 12 insertions(+), 14 deletions(-)

diff --git a/reference/reflection/reflectiongenerator/isclosed.xml b/reference/reflection/reflectiongenerator/isclosed.xml
index 69a08faeb5b3..fb4513ddc100 100644
--- a/reference/reflection/reflectiongenerator/isclosed.xml
+++ b/reference/reflection/reflectiongenerator/isclosed.xml
@@ -12,9 +12,9 @@
    <modifier>public</modifier> <type>bool</type><methodname>ReflectionGenerator::isClosed</methodname>
    <void/>
   </methodsynopsis>
-  <para>
+  <simpara>
    Returns whether the execution reached the end of the function, a return statement or if an exception was thrown.
-  </para>
+  </simpara>
  </refsect1>
 
  <refsect1 role="parameters">
@@ -24,17 +24,16 @@
 
  <refsect1 role="returnvalues">
   &reftitle.returnvalues;
-  <para>
+  <simpara>
    Returns whether the generator finished executing.
-  </para>
+  </simpara>
  </refsect1>
 
   <refsect1 role="examples">
   &reftitle.examples;
-  <para>
-   <example>
-    <title><methodname>ReflectionGenerator::isClosed</methodname> example</title>
-    <programlisting role="php">
+  <example>
+   <title><methodname>ReflectionGenerator::isClosed</methodname> example</title>
+   <programlisting role="php">
 <![CDATA[
 <?php
 
@@ -56,9 +55,9 @@ var_dump($reflectionGen->isClosed());
 
 ?>
 ]]>
-    </programlisting>
-    &example.outputs;
-    <screen>
+   </programlisting>
+   &example.outputs;
+   <screen>
 <![CDATA[
 a
 bool(false)
@@ -66,9 +65,8 @@ a
 bool(false)
 bool(true)
 ]]>
-    </screen>
-   </example>
-  </para>
+   </screen>
+  </example>
  </refsect1>
 
 </refentry>