From 12e82b257e2cce3418e5f886ab682422cb5f9485 Mon Sep 17 00:00:00 2001
From: Gina Peter Banyard <girgias@php.net>
Date: Mon, 11 Nov 2024 14:02:36 +0000
Subject: [PATCH 1/3] PHP 8.4: Document reflection changes

Drive-by fix for 8.1 ommision
---
 reference/reflection/reflectionattribute.xml  | 43 +++++++++
 .../reflectionclass/resetaslazyghost.xml      |  4 +-
 .../reflection/reflectionmethod/construct.xml |  7 ++
 reference/reflection/reflectionproperty.xml   | 94 +++++++++++++++++++
 .../reflection/reflectionproperty/islazy.xml  |  2 +-
 .../setrawvaluewithoutlazyinitialization.xml  |  2 +-
 6 files changed, 148 insertions(+), 4 deletions(-)

diff --git a/reference/reflection/reflectionattribute.xml b/reference/reflection/reflectionattribute.xml
index bfe5432ab93f..f9b9f4dad64c 100644
--- a/reference/reflection/reflectionattribute.xml
+++ b/reference/reflection/reflectionattribute.xml
@@ -39,6 +39,13 @@
      <varname linkend="reflectionattribute.constants.is-instanceof">ReflectionAttribute::IS_INSTANCEOF</varname>
     </fieldsynopsis>
 
+    <classsynopsisinfo role="comment">&Properties;</classsynopsisinfo>
+    <fieldsynopsis>
+     <modifier>public</modifier>
+     <type>string</type>
+     <varname linkend="reflectionattribute.props.name">name</varname>
+    </fieldsynopsis>
+
     <classsynopsisinfo role="comment">&Methods;</classsynopsisinfo>
     <xi:include xpointer="xmlns(db=http://docbook.org/ns/docbook) xpointer(id('class.reflectionattribute')/db:refentry/db:refsect1[@role='description']/descendant::db:constructorsynopsis[@role='ReflectionAttribute'])">
      <xi:fallback/>
@@ -51,6 +58,20 @@
 
   </section>
 
+  <section xml:id="reflectionattribute.props">
+   &reftitle.properties;
+   <variablelist>
+    <varlistentry xml:id="reflectionattribute.props.name">
+     <term><varname>name</varname></term>
+     <listitem>
+      <simpara>
+       The name of the attribute.
+      </simpara>
+     </listitem>
+    </varlistentry>
+   </variablelist>
+  </section>
+
   <!-- {{{ ReflectionAttribute constants -->
   <section xml:id="reflectionattribute.constants">
    &reftitle.constants;
@@ -80,6 +101,28 @@
   </section>
   <!-- }}} -->
 
+  <section role="changelog">
+   &reftitle.changelog;
+   <informaltable>
+    <tgroup cols="2">
+     <thead>
+      <row>
+       <entry>&Version;</entry>
+       <entry>&Description;</entry>
+      </row>
+     </thead>
+     <tbody>
+      <row>
+       <entry>8.4.0</entry>
+       <entry>
+        Added <property>ReflectionAttribute::$name</property>.
+       </entry>
+      </row>
+     </tbody>
+    </tgroup>
+   </informaltable>
+  </section>
+
  </partintro>
 
  &reference.reflection.entities.reflectionattribute;
diff --git a/reference/reflection/reflectionclass/resetaslazyghost.xml b/reference/reflection/reflectionclass/resetaslazyghost.xml
index 1202bc9b272a..f91264185ad3 100644
--- a/reference/reflection/reflectionclass/resetaslazyghost.xml
+++ b/reference/reflection/reflectionclass/resetaslazyghost.xml
@@ -10,7 +10,7 @@
   <methodsynopsis role="ReflectionClass">
    <modifier>public</modifier> <type>void</type><methodname>ReflectionClass::resetAsLazyGhost</methodname>
    <methodparam><type>object</type><parameter>object</parameter></methodparam>
-   <methodparam><type>callable</type><parameter>initializer</parameter></methodparam>
+   <methodparam><type>callable</type><parameter>factory</parameter></methodparam>
    <methodparam choice="opt"><type>int</type><parameter>options</parameter><initializer>0</initializer></methodparam>
   </methodsynopsis>
   <simpara>
@@ -69,7 +69,7 @@
     </listitem>
    </varlistentry>
    <varlistentry>
-    <term><parameter>initializer</parameter></term>
+    <term><parameter>factory</parameter></term>
     <listitem>
      <simpara>
       An initializer callback with the same signature and purpose as in
diff --git a/reference/reflection/reflectionmethod/construct.xml b/reference/reflection/reflectionmethod/construct.xml
index 77ecbc2c353f..23ba43556a88 100644
--- a/reference/reflection/reflectionmethod/construct.xml
+++ b/reference/reflection/reflectionmethod/construct.xml
@@ -18,6 +18,13 @@
    <modifier>public</modifier> <methodname>ReflectionMethod::__construct</methodname>
    <methodparam><type>string</type><parameter>classMethod</parameter></methodparam>
   </constructorsynopsis>
+  <warning>
+   <simpara>
+    The alternative signature is deprecated as of PHP 8.4.0,
+    use <methodname>ReflectionMethod::createFromMethodName</methodname>
+    instead.
+   </simpara>
+  </warning>
   <para>
    Constructs a new <classname>ReflectionMethod</classname>.
   </para>
diff --git a/reference/reflection/reflectionproperty.xml b/reference/reflection/reflectionproperty.xml
index 4a9605c32f3b..522b38e25747 100644
--- a/reference/reflection/reflectionproperty.xml
+++ b/reference/reflection/reflectionproperty.xml
@@ -62,6 +62,36 @@
      <type>int</type>
      <varname linkend="reflectionproperty.constants.is-private">ReflectionProperty::IS_PRIVATE</varname>
     </fieldsynopsis>
+    <fieldsynopsis>
+     <modifier>public</modifier>
+     <modifier>const</modifier>
+     <type>int</type>
+     <varname linkend="reflectionproperty.constants.is-abstract">ReflectionProperty::IS_ABSTRACT</varname>
+    </fieldsynopsis>
+    <fieldsynopsis>
+     <modifier>public</modifier>
+     <modifier>const</modifier>
+     <type>int</type>
+     <varname linkend="reflectionproperty.constants.is-protected-set">ReflectionProperty::IS_PROTECTED_SET</varname>
+    </fieldsynopsis>
+    <fieldsynopsis>
+     <modifier>public</modifier>
+     <modifier>const</modifier>
+     <type>int</type>
+     <varname linkend="reflectionproperty.constants.is-private-set">ReflectionProperty::IS_PRIVATE_SET</varname>
+    </fieldsynopsis>
+    <fieldsynopsis>
+     <modifier>public</modifier>
+     <modifier>const</modifier>
+     <type>int</type>
+     <varname linkend="reflectionproperty.constants.is-virtual">ReflectionProperty::IS_VIRTUAL</varname>
+    </fieldsynopsis>
+    <fieldsynopsis>
+     <modifier>public</modifier>
+     <modifier>const</modifier>
+     <type>int</type>
+     <varname linkend="reflectionproperty.constants.is-final">ReflectionProperty::IS_FINAL</varname>
+    </fieldsynopsis>
 
     <classsynopsisinfo role="comment">&Properties;</classsynopsisinfo>
     <fieldsynopsis>
@@ -176,6 +206,55 @@
       </listitem>
      </varlistentry>
 
+     <varlistentry xml:id="reflectionproperty.constants.is-abstract">
+      <term><constant>ReflectionProperty::IS_ABSTRACT</constant></term>
+      <listitem>
+       <simpara>
+        Indicates the property is
+        <link linkend="language.oop5.abstract">abstract</link>.
+        Available as of PHP 8.4.0.
+       </simpara>
+      </listitem>
+     </varlistentry>
+
+     <varlistentry xml:id="reflectionproperty.constants.is-protected-set">
+      <term><constant>ReflectionProperty::IS_PROTECTED_SET</constant></term>
+      <listitem>
+       <simpara>
+        Available as of PHP 8.4.0.
+       </simpara>
+      </listitem>
+     </varlistentry>
+
+     <varlistentry xml:id="reflectionproperty.constants.is-private-set">
+      <term><constant>ReflectionProperty::IS_PRIVATE_SET</constant></term>
+      <listitem>
+       <simpara>
+        Available as of PHP 8.4.0.
+       </simpara>
+      </listitem>
+     </varlistentry>
+
+     <varlistentry xml:id="reflectionproperty.constants.is-virtual">
+      <term><constant>ReflectionProperty::IS_VIRTUAL</constant></term>
+      <listitem>
+       <simpara>
+        Available as of PHP 8.4.0.
+       </simpara>
+      </listitem>
+     </varlistentry>
+
+     <varlistentry xml:id="reflectionproperty.constants.is-final">
+      <term><constant>ReflectionProperty::IS_FINAL</constant></term>
+      <listitem>
+       <simpara>
+        Indicates the property is
+        <link linkend="language.oop5.final">final</link>.
+        Available as of PHP 8.1.0.
+       </simpara>
+      </listitem>
+     </varlistentry>
+
     </variablelist>
     <note>
      <para>
@@ -199,6 +278,21 @@
       </row>
      </thead>
      <tbody>
+      <row>
+       <entry>8.4.0</entry>
+       <entry>
+        Added <constant>ReflectionProperty::IS_VIRTUAL</constant>,
+        <constant>ReflectionProperty::IS_PRIVATE_SET</constant>,
+        <constant>ReflectionProperty::IS_PROTECTED_SET</constant>,
+        <constant>ReflectionProperty::IS_ABSTRACT</constant>.
+       </entry>
+      </row>
+      <row>
+       <entry>8.1.0</entry>
+       <entry>
+        Added <constant>ReflectionProperty::IS_FINAL</constant>.
+       </entry>
+      </row>
       <row>
        <entry>8.0.0</entry>
        <entry>
diff --git a/reference/reflection/reflectionproperty/islazy.xml b/reference/reflection/reflectionproperty/islazy.xml
index 9bd233e056db..d177e9f83eb2 100644
--- a/reference/reflection/reflectionproperty/islazy.xml
+++ b/reference/reflection/reflectionproperty/islazy.xml
@@ -7,7 +7,7 @@
 
  <refsect1 role="description">
   &reftitle.description;
-  <methodsynopsis>
+  <methodsynopsis role="ReflectionProperty">
    <modifier>public</modifier> <type>bool</type><methodname>ReflectionProperty::isLazy</methodname>
    <methodparam><type>object</type><parameter>object</parameter></methodparam>
   </methodsynopsis>
diff --git a/reference/reflection/reflectionproperty/setrawvaluewithoutlazyinitialization.xml b/reference/reflection/reflectionproperty/setrawvaluewithoutlazyinitialization.xml
index da0841125007..176825d34e45 100644
--- a/reference/reflection/reflectionproperty/setrawvaluewithoutlazyinitialization.xml
+++ b/reference/reflection/reflectionproperty/setrawvaluewithoutlazyinitialization.xml
@@ -10,7 +10,7 @@
   <methodsynopsis role="ReflectionProperty">
    <modifier>public</modifier> <type>void</type><methodname>ReflectionProperty::setRawValueWithoutLazyInitialization</methodname>
    <methodparam><type>object</type><parameter>object</parameter></methodparam>
-   <methodparam><type class="union"><type>mixed</type><type>null</type></type><parameter>value</parameter></methodparam>
+   <methodparam><type>mixed</type><parameter>value</parameter></methodparam>
   </methodsynopsis>
   <simpara>
    Sets (changes) the property's value without triggering lazy initialization

From 83d18a165166eda6a6818d34967f400cb7c250a5 Mon Sep 17 00:00:00 2001
From: Gina Peter Banyard <girgias@php.net>
Date: Tue, 12 Nov 2024 14:32:50 +0000
Subject: [PATCH 2/3] revert ReflectionClass::resetAsLazyGhost param name
 change

This is being fixed in php-src
---
 reference/reflection/reflectionclass/resetaslazyghost.xml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/reference/reflection/reflectionclass/resetaslazyghost.xml b/reference/reflection/reflectionclass/resetaslazyghost.xml
index f91264185ad3..1202bc9b272a 100644
--- a/reference/reflection/reflectionclass/resetaslazyghost.xml
+++ b/reference/reflection/reflectionclass/resetaslazyghost.xml
@@ -10,7 +10,7 @@
   <methodsynopsis role="ReflectionClass">
    <modifier>public</modifier> <type>void</type><methodname>ReflectionClass::resetAsLazyGhost</methodname>
    <methodparam><type>object</type><parameter>object</parameter></methodparam>
-   <methodparam><type>callable</type><parameter>factory</parameter></methodparam>
+   <methodparam><type>callable</type><parameter>initializer</parameter></methodparam>
    <methodparam choice="opt"><type>int</type><parameter>options</parameter><initializer>0</initializer></methodparam>
   </methodsynopsis>
   <simpara>
@@ -69,7 +69,7 @@
     </listitem>
    </varlistentry>
    <varlistentry>
-    <term><parameter>factory</parameter></term>
+    <term><parameter>initializer</parameter></term>
     <listitem>
      <simpara>
       An initializer callback with the same signature and purpose as in

From cf68819a55900dccdc301a35e74d8990363f71af Mon Sep 17 00:00:00 2001
From: Gina Peter Banyard <girgias@php.net>
Date: Tue, 12 Nov 2024 14:35:23 +0000
Subject: [PATCH 3/3] Fix IS_FINAL for property is available as of 8.4.0

---
 reference/reflection/reflectionproperty.xml | 11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)

diff --git a/reference/reflection/reflectionproperty.xml b/reference/reflection/reflectionproperty.xml
index 522b38e25747..73c8ceef43c5 100644
--- a/reference/reflection/reflectionproperty.xml
+++ b/reference/reflection/reflectionproperty.xml
@@ -250,7 +250,7 @@
        <simpara>
         Indicates the property is
         <link linkend="language.oop5.final">final</link>.
-        Available as of PHP 8.1.0.
+        Available as of PHP 8.4.0.
        </simpara>
       </listitem>
      </varlistentry>
@@ -284,13 +284,8 @@
         Added <constant>ReflectionProperty::IS_VIRTUAL</constant>,
         <constant>ReflectionProperty::IS_PRIVATE_SET</constant>,
         <constant>ReflectionProperty::IS_PROTECTED_SET</constant>,
-        <constant>ReflectionProperty::IS_ABSTRACT</constant>.
-       </entry>
-      </row>
-      <row>
-       <entry>8.1.0</entry>
-       <entry>
-        Added <constant>ReflectionProperty::IS_FINAL</constant>.
+        <constant>ReflectionProperty::IS_ABSTRACT</constant>,
+        and <constant>ReflectionProperty::IS_FINAL</constant>.
        </entry>
       </row>
       <row>