Remove MYSQLI_IS_MARIADB constant

Author: kamil-tekiela

ext/mysqli/mysqli.c

@@ -688,12 +688,6 @@ PHP_MINIT_FUNCTION(mysqli)
 	REGISTER_LONG_CONSTANT("MYSQLI_TRANS_COR_RELEASE", TRANS_COR_RELEASE, CONST_CS | CONST_PERSISTENT);
 	REGISTER_LONG_CONSTANT("MYSQLI_TRANS_COR_NO_RELEASE", TRANS_COR_NO_RELEASE, CONST_CS | CONST_PERSISTENT);
 
-#ifdef MARIADB_BASE_VERSION
-	REGISTER_BOOL_CONSTANT("MYSQLI_IS_MARIADB", 1, CONST_CS | CONST_PERSISTENT);
-#else
-	REGISTER_BOOL_CONSTANT("MYSQLI_IS_MARIADB", 0, CONST_CS | CONST_PERSISTENT);
-#endif
-
 	register_mysqli_symbols(module_number);
 
 	mysqlnd_reverse_api_register_api(&mysqli_reverse_api);

ext/mysqli/tests/mysqli_constants.phpt

@@ -47,7 +47,7 @@ $expected_constants = array(
     "MYSQLI_GROUP_FLAG" 				=> true,
     "MYSQLI_SERVER_QUERY_NO_GOOD_INDEX_USED"=> true,
     "MYSQLI_SERVER_QUERY_NO_INDEX_USED"	=> true,
-    "MYSQLI_IS_MARIADB"                 => true,
+    "MYSQLI_OPT_LOAD_DATA_LOCAL_DIR"    => true,
 
     "MYSQLI_TYPE_DECIMAL"				=> true,
     "MYSQLI_TYPE_TINY"					=> true,
@@ -181,10 +181,6 @@ if ($IS_MYSQLND) {
     $expected_constants["MYSQLI_TYPE_JSON"]	= true;
 }
 
-if (($version > 80021 && $constants['mysqli']['MYSQLI_IS_MARIADB']) || $IS_MYSQLND) {
-    $expected_constants['MYSQLI_OPT_LOAD_DATA_LOCAL_DIR'] = true;
-}
-
 $unexpected_constants = array();
 
 foreach ($constants as $group => $consts) {