Skip to content

Fix: Do not pass null to function that expects string #12882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

localheinz
Copy link
Contributor

This pull request

  • stops passing null to a function that expects string

Follows php/web-php#850.

@kamil-tekiela
Copy link
Member

I don't think this deprecation warning happens here. We use this on master and there are no warnings. If you diff the two files, you will see that the one in web-php is a much older version. What I proposed is that we just copy over the latest version from php-src into web-php. I don't think there is a need to change $php declaration here or there for that matter. Sorry for the confusion.

@localheinz localheinz closed this Dec 6, 2023
@localheinz localheinz deleted the fix/null branch December 6, 2023 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants