From 8d75d8f0ee7cc12c11c95b730754ca068ecf1626 Mon Sep 17 00:00:00 2001 From: Niels Dossche <7771979+nielsdos@users.noreply.github.com> Date: Tue, 16 Jul 2024 18:06:06 +0200 Subject: [PATCH] Fix references in request_parse_body() options array Otherwise we get funny messages like "Invalid string value in $options argument". --- ext/standard/http.c | 1 + .../options_array_references.phpt | 14 ++++++++++++++ 2 files changed, 15 insertions(+) create mode 100644 ext/standard/tests/http/request_parse_body/options_array_references.phpt diff --git a/ext/standard/http.c b/ext/standard/http.c index a9e56d4516191..7a4a58755d894 100644 --- a/ext/standard/http.c +++ b/ext/standard/http.c @@ -244,6 +244,7 @@ static zend_result cache_request_parse_body_option(HashTable *options, zval *opt { if (option) { zend_long result; + ZVAL_DEREF(option); if (Z_TYPE_P(option) == IS_STRING) { zend_string *errstr; result = zend_ini_parse_quantity(Z_STR_P(option), &errstr); diff --git a/ext/standard/tests/http/request_parse_body/options_array_references.phpt b/ext/standard/tests/http/request_parse_body/options_array_references.phpt new file mode 100644 index 0000000000000..6c6c0c1576516 --- /dev/null +++ b/ext/standard/tests/http/request_parse_body/options_array_references.phpt @@ -0,0 +1,14 @@ +--TEST-- +request_parse_body: reference in options array +--FILE-- + '128M']; +foreach ($options as $k => &$v) {} +try { + request_parse_body($options); +} catch (Throwable $e) { + echo $e->getMessage(), "\n"; +} +?> +--EXPECT-- +Request does not provide a content type