Support new PHP8.4 mb_lcfirst, mb_ucfirst function variants

Author: staabm

src/Analyser/TypeSpecifier.php

@@ -1017,9 +1017,9 @@ private function specifyTypesForConstantStringBinaryExpression(
 			&& $exprNode instanceof FuncCall
 			&& $exprNode->name instanceof Name
 			&& in_array(strtolower($exprNode->name->toString()), [
-				'substr', 'strstr', 'stristr', 'strchr', 'strrchr', 'strtolower', 'strtoupper',
-				'mb_substr', 'mb_strstr', 'mb_stristr', 'mb_strchr', 'mb_strrchr', 'mb_strtolower', 'mb_strtoupper',
-				'ucfirst', 'lcfirst', 'ucwords', 'mb_convert_case', 'mb_convert_kana',
+				'substr', 'strstr', 'stristr', 'strchr', 'strrchr', 'strtolower', 'strtoupper', 'ucfirst', 'lcfirst',
+				'mb_substr', 'mb_strstr', 'mb_stristr', 'mb_strchr', 'mb_strrchr', 'mb_strtolower', 'mb_strtoupper', 'mb_ucfirst', 'mb_lcfirst',
+				'ucwords', 'mb_convert_case', 'mb_convert_kana',
 			], true)
 			&& isset($exprNode->getArgs()[0])
 			&& $constantType->getValue() !== ''

src/Type/Php/StrCaseFunctionsReturnTypeExtension.php

@@ -34,6 +34,8 @@ class StrCaseFunctionsReturnTypeExtension implements DynamicFunctionReturnTypeEx
 		'mb_strtolower' => 1,
 		'lcfirst' => 1,
 		'ucfirst' => 1,
+		'mb_lcfirst' => 1,
+		'mb_ucfirst' => 1,
 		'ucwords' => 1,
 		'mb_convert_case' => 2,
 		'mb_convert_kana' => 1,

tests/PHPStan/Analyser/data/str-casing.php

@@ -25,6 +25,8 @@ public function bar($numericS, $nonE, $literal, $edgeUnion, $caseMode, $kanaMode
 		assertType("'ＡＢＣ'", mb_strtoupper('Ａｂｃ'));
 		assertType("'aBC'", lcfirst('ABC'));
 		assertType("'Abc'", ucfirst('abc'));
+		assertType("'aBC'", mb_lcfirst('ABC'));
+		assertType("'Abc'", mb_ucfirst('abc'));
 		assertType("'Hello World'", ucwords('hello world'));
 		assertType("'Hello|World'", ucwords('hello|world', "|"));
 		assertType("'ČESKÁ REPUBLIKA'", mb_convert_case('Česká republika', MB_CASE_UPPER));
@@ -43,6 +45,8 @@ public function bar($numericS, $nonE, $literal, $edgeUnion, $caseMode, $kanaMode
 		assertType("numeric-string", mb_strtoupper($numericS));
 		assertType("numeric-string", lcfirst($numericS));
 		assertType("numeric-string", ucfirst($numericS));
+		assertType("numeric-string", mb_lcfirst($numericS));
+		assertType("numeric-string", mb_ucfirst($numericS));
 		assertType("numeric-string", ucwords($numericS));
 		assertType("numeric-string", mb_convert_case($numericS, MB_CASE_UPPER));
 		assertType("numeric-string", mb_convert_case($numericS, MB_CASE_LOWER));
@@ -56,6 +60,8 @@ public function bar($numericS, $nonE, $literal, $edgeUnion, $caseMode, $kanaMode
 		assertType("non-empty-string", mb_strtoupper($nonE));
 		assertType("non-empty-string", lcfirst($nonE));
 		assertType("non-empty-string", ucfirst($nonE));
+		assertType("non-empty-string", mb_lcfirst($nonE));
+		assertType("non-empty-string", mb_ucfirst($nonE));
 		assertType("non-empty-string", ucwords($nonE));
 		assertType("non-empty-string", mb_convert_case($nonE, MB_CASE_UPPER));
 		assertType("non-empty-string", mb_convert_case($nonE, MB_CASE_LOWER));
@@ -69,6 +75,8 @@ public function bar($numericS, $nonE, $literal, $edgeUnion, $caseMode, $kanaMode
 		assertType("string", mb_strtoupper($literal));
 		assertType("string", lcfirst($literal));
 		assertType("string", ucfirst($literal));
+		assertType("string", mb_lcfirst($literal));
+		assertType("string", mb_ucfirst($literal));
 		assertType("string", ucwords($literal));
 		assertType("string", mb_convert_case($literal, MB_CASE_UPPER));
 		assertType("string", mb_convert_case($literal, MB_CASE_LOWER));