Skip to content

Commit 1669e08

Browse files
committed
Refactor enable_dev_tools variables names.
1 parent 72a0db7 commit 1669e08

File tree

1 file changed

+26
-24
lines changed

1 file changed

+26
-24
lines changed

dash/dash.py

Lines changed: 26 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -216,7 +216,9 @@ def add_url(name, view_func, methods=('GET',)):
216216
self._layout = None
217217
self._cached_layout = None
218218
self.routes = []
219-
self._serve_dev_bundle = False
219+
self._dev_tools = _AttributeDict({
220+
'serve_dev_bundles': False
221+
})
220222

221223
@property
222224
def layout(self):
@@ -359,13 +361,13 @@ def _generate_scripts_html(self):
359361
srcs = self._collect_and_register_resources(
360362
self.scripts._resources._filter_resources(
361363
dash_renderer._js_dist_dependencies,
362-
dev_bundles=self._serve_dev_bundle
364+
dev_bundles=self._dev_tools.serve_dev_bundles
363365
)) + self._external_scripts + self._collect_and_register_resources(
364366
self.scripts.get_all_scripts(
365-
dev_bundles=self._serve_dev_bundle) +
367+
dev_bundles=self._dev_tools.serve_dev_bundles) +
366368
self.scripts._resources._filter_resources(
367369
dash_renderer._js_dist,
368-
dev_bundles=self._serve_dev_bundle
370+
dev_bundles=self._dev_tools.serve_dev_bundles
369371
))
370372

371373
return '\n'.join([
@@ -954,46 +956,46 @@ def get_asset_url(self, path):
954956
self.config.routes_pathname_prefix,
955957
path)
956958

957-
def activate_dev_tools(self,
958-
dev_tools=True,
959-
dev_tools_bundles=True):
959+
def enable_dev_tools(self,
960+
debug=False,
961+
dev_tools_serve_bundles=None):
960962
"""
961963
Activate the dev tools, called by `run_server`. If your application is
962964
served by wsgi and you want to activate the dev tools, you can call
963965
this method out of `__main__`.
964966
965-
:param dev_tools: If false no tools will be activated.
966-
:type dev_tools: bool
967-
:param dev_tools_bundles: Serve the dev bundles of component libs.
968-
:type dev_tools_bundles: bool
967+
:param debug: If false no tools will be activated.
968+
:type debug: bool
969+
:param dev_tools_serve_bundles: Serve the dev bundles of component libs.
970+
:type dev_tools_serve_bundles: bool
969971
:return:
970972
"""
971-
if not dev_tools:
973+
if not debug:
972974
return
973-
self._serve_dev_bundle = dev_tools_bundles
975+
976+
env = _configs.env_configs()
977+
978+
self._dev_tools['serve_dev_bundles'] = _configs.get_config(
979+
'serve_dev_bundles', dev_tools_serve_bundles, env, True)
974980

975981
def run_server(self,
976982
port=8050,
977983
debug=False,
978-
dev_tools=True,
979-
dev_tools_bundles=True,
984+
dev_tools_serve_dev_bundles=None,
980985
**flask_run_options):
981986
"""
982987
Start the flask server in local mode, you should not run this on a
983-
production server and use gunicorn/waitress instead. By default will
984-
activate the dev tools (dev bundles).
988+
production server and use gunicorn/waitress instead.
985989
986990
:param port: Port the application
987991
:type port: int
988-
:param debug: Set the debug mode of flask.
992+
:param debug: Set the debug mode of flask and enable the dev tools.
989993
:type debug: bool
990-
:param dev_tools: Activate all the dev tools.
991-
:type dev_tools: bool
992-
:param dev_tools_bundles: Serve the dev bundles of component libs.
993-
:type dev_tools_bundles: bool
994+
:param dev_tools_serve_dev_bundles: Serve the dev bundles of component libs.
995+
:type dev_tools_serve_dev_bundles: bool
994996
:param flask_run_options: Given to `Flask.run`
995997
:return:
996998
"""
997-
self.activate_dev_tools(dev_tools, dev_tools_bundles)
998-
self.server.run(port=port, debug=dev_tools or debug,
999+
self.enable_dev_tools(debug, dev_tools_serve_dev_bundles)
1000+
self.server.run(port=port, debug=debug,
9991001
**flask_run_options)

0 commit comments

Comments
 (0)