Merge 16df17c into 789e1ec

Author: cpsievert

R/trace_generation.R

@@ -252,9 +252,14 @@ layer2traces <- function(l, d, misc) {
     if (g$geom == "bar") {
       tr$bargap <- if (exists("bargap")) bargap else "default"
       pos <- l$position$.super$objname
-      tr$barmode <- if (pos %in% c("identity", "stack", "fill")) {
-        "stack"
-      } else "group"
+      tr$barmode <-
+        if (pos %in% "identity" && tr$bargap == 0) {
+          "overlay" 
+        } else if (pos %in% c("identity", "stack", "fill")) {
+          "stack"
+        } else {
+        "group"
+      }
     }
 
     traces <- c(traces, list(tr))
@@ -579,11 +584,15 @@ geom2trace <- list(
       # Convert days into milliseconds
       x <- as.numeric(x) * 24 * 60 * 60 * 1000
     }
-    L <- list(x=x,
-              y=data$y,
+    # if there is more than one y-value for a particular combination of 
+    # x, PANEL, and group; then take the _max_ y.
+    data$x <- x
+    dat <- plyr::ddply(data, c("x", "PANEL", if("group"%in%names(data))"group"), 
+                       plyr::summarise, count = max(y))
+    L <- list(x=dat$x,
+              y=dat$count,
               type="bar",
               name=params$name,
-              text=data$text,
               marker=list(color=toRGB(params$fill)))
     if (!is.null(params$colour)) {
       L$marker$line <- list(color=toRGB(params$colour))

tests/testthat/test-ggplot-bar.R

@@ -191,3 +191,16 @@ test_that("geom_bar(position = 'fill') stacks proportions", {
   expect_identical(prop, 1)
 })
 
+d <- head(diamonds, 50)
+gbar <- ggplot(d, aes(cut, price)) + geom_bar(stat = "identity")
+
+test_that("For a given x value, if multiple y exist, sum them. ", {
+  info <- expect_traces(gbar, 1, "category-names")
+  expect_identical(info$traces[[1]]$type, "bar")
+  y <- with(d, tapply(price, cut, sum))
+  # make sure order of counts match
+  y <- y[info$traces[[1]]$x]
+  expect_equal(info$traces[[1]]$y, as.numeric(y))
+})
+
+

tests/testthat/test-ggplot-categorical.R

@@ -11,17 +11,3 @@ test_that("axis type=category when we plot factors", {
 
   save_outputs(gg, "bar-factor-category")
 })
-
-test_that("Bar charts of type=category show category names", {
-  gbar <- ggplot(d, aes(cut, price)) + geom_bar(stat="identity")
-  info <- gg2list(gbar)
-  
-  expect_equal(length(info$data), 1)  # 1 trace
-  expect_identical(info$layout$xaxis$type, "category")
-  expect_identical(info$layout$xaxis$title, "cut")
-  expect_identical(info$layout$yaxis$type, "linear")
-  expect_true(all(c("Fair", "Good", "Very Good", "Premium", "Ideal") %in%
-                    info$data[[1]]$x))
-  
-  save_outputs(gbar, "bar-category-names")
-})

tests/testthat/test-ggplot-density.R

@@ -26,7 +26,8 @@ test_that("geom_density() is translated to area chart", {
 })
 
 test_that("geom_density() respects fill aesthetic", {
-  info <- expect_traces(base + geom_density(aes(fill=factor(vs))), 2, "fill")
+  gg <- base + geom_density(aes(fill=factor(vs)), alpha = 0.3)
+  info <- expect_traces(gg, 2, "fill")
   trs <- info$traces
   type <- unique(sapply(trs, "[[", "type"))
   fill <- unique(sapply(trs, "[[", "fill"))
@@ -42,3 +43,14 @@ test_that("geom_density() respects colour aesthetic", {
   expect_identical(type, "scatter")
   expect_identical(fill, "tozeroy")
 })
+
+g <- base + 
+  geom_histogram(aes(y = ..density..), binwidth = 0.5, fill = "pink") +
+  geom_density(fill = "lightblue", alpha = 0.1)
+  
+test_that("geom_histogram(aes(y = ..density..)) + geom_density() works", {
+  info <- expect_traces(g, 2, "color")
+  trs <- info$traces
+  type <- unique(sapply(trs, "[[", "type"))
+  expect_identical(sort(type), c("bar", "scatter"))
+})

tests/testthat/test-ggplot-histogram.R

@@ -47,7 +47,7 @@ test_that("geom_histogram(aes(fill = ..count..)) works", {
   }
 })
 
-test_that("Fixed colour/fill works", {
+test_that("Histogram with fixed colour/fill works", {
   gg <- base + geom_histogram(colour = "darkgreen", fill = "white")
   info <- expect_traces(gg, 1, "fixed-fill-color")
   tr <- info$traces[[1]]
@@ -63,6 +63,69 @@ test_that("Specify histogram binwidth", {
   expect_equal(area, 1, 0.1)
 })
 
+test_that("geom_histogram(aes(fill = factor(...))) is a stacked by default", {
+  gg <- base + geom_histogram(aes(fill = factor(vs)))
+  info <- expect_traces(gg, 2, "fill-factor")
+  trs <- info$traces
+  type <- unique(sapply(trs, "[[", "type"))
+  gap <- unique(sapply(trs, "[[", "bargap"))
+  barmode <- unique(sapply(trs, "[[", "barmode"))
+  expect_identical(type, "bar")
+  expect_equal(gap, 0)
+  expect_equal(barmode, "stack")
+})
+
+test_that("geom_histogram(aes(fill = factor(...))) respects position_identity()", {
+  gg <- base + geom_histogram(aes(fill = factor(vs)), alpha = 0.3,
+                              position = "identity")
+  info <- expect_traces(gg, 2, "fill-factor-identity")
+  trs <- info$traces
+  type <- unique(sapply(trs, "[[", "type"))
+  gap <- unique(sapply(trs, "[[", "bargap"))
+  barmode <- unique(sapply(trs, "[[", "barmode"))
+  expect_identical(type, "bar")
+  expect_equal(gap, 0)
+  expect_equal(barmode, "overlay")
+})
+
+test_that("geom_histogram(aes(fill = factor(...))) respects position_dodge()", {
+  gg <- base + geom_histogram(aes(fill = factor(vs)), alpha = 0.3,
+                              position = "dodge")
+  info <- expect_traces(gg, 2, "fill-factor-dodge")
+  trs <- info$traces
+  type <- unique(sapply(trs, "[[", "type"))
+  gap <- unique(sapply(trs, "[[", "bargap"))
+  barmode <- unique(sapply(trs, "[[", "barmode"))
+  expect_identical(type, "bar")
+  expect_equal(gap, 0)
+  expect_equal(barmode, "group")
+})
+
+test_that("geom_histogram() with facets", {
+  gg <- base + geom_histogram(aes(fill = factor(vs)), alpha = 0.3) + 
+    facet_wrap(~am)
+  info <- expect_traces(gg, 4, "fill-factor-facets")
+  trs <- info$traces
+  type <- unique(sapply(trs, "[[", "type"))
+  gap <- unique(sapply(trs, "[[", "bargap"))
+  barmode <- unique(sapply(trs, "[[", "barmode"))
+  expect_identical(type, "bar")
+  expect_equal(gap, 0)
+  expect_equal(barmode, "stack")
+})
+
+test_that("vline overlaid histogram", {
+  gg <- base + geom_histogram() +
+    geom_vline(aes(xintercept=mean(wt)), color="red", linetype="dashed", size=1)
+  info <- expect_traces(gg, 2, "vline")
+  trs <- info$traces
+  type <- unique(sapply(trs, "[[", "type"))
+  expect_identical(sort(type), c("bar", "scatter"))
+})
+
+
+
+
 # Non-numeric (date) data
 noram <- data.frame(month=c("2012-01-01", "2012-02-01", "2012-01-01",
                             "2012-01-01", "2012-03-01", "2012-02-01"))