xaxis for shapes doesn't support Date objects

[cambridgemike]

even if the xaxis is specified as 'date' type, your shapes must have x-values of millisecond integers, not date objects (unlike plots).

[etpinard]

That's correct.

If I remember correctly, xaxis.range and yaxis.range need millisecond integers too, That is, they need to be converted with (new Date(yyyy, mm, dd)).getTime().

I agree, this is far from ideal. Thanks for bringing this up.

[cambridgemike]

At the least an update to the documentation would have been really helpful
and saved some time debugging.

On Wed, May 4, 2016 at 8:02 AM, Étienne Tétreault-Pinard <
notifications@github.com> wrote:

That's correct.

If I remember correctly, xaxis.range and yaxis.range need millisecond
integers too, That is, they need to be converted with (new Date(yyyy, mm,
dd)).getTime().

I agree, this is far from ideal. Thanks for bringing this up.

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#501 (comment)

[etpinard]

Agreed.

We should copy some of the info about axis.range to the shape attributes.

This would be a good oppurtunity for a first-time contributor.

[cambridgemike]

haha, fine fine :) I'll send a pull request later today

On Wed, May 4, 2016 at 8:14 AM, Étienne Tétreault-Pinard <
notifications@github.com> wrote:

Agreed.

We should copy some of the info about axis.range

plotly.js/src/components/rangeslider/attributes.js

Lines 41 to 46 in d8e27dd

	'Sets the range of the range slider.',
	'If not set, defaults to the full xaxis range.',
	'If the axis `type` is *log*, then you must take the',
	'log of your desired range.',
	'If the axis `type` is *date*, then you must convert',
	'the date to unix time in milliseconds.'

to the shape attributes
https://github.com/plotly/plotly.js/blob/d8e27dd33270aa7e4bb01a612cc99c51fa3cb68a/src/components/shapes/attributes.js
.

This would be a good oppurtunity for a first-time contributor.

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#501 (comment)