From 87f89ebe5558940998094372b563c5c9b42a7028 Mon Sep 17 00:00:00 2001 From: Mojtaba Samimi Date: Thu, 12 Jan 2023 10:46:24 -0500 Subject: [PATCH 1/3] convert is-mobile to es5 --- webpack.config.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/webpack.config.js b/webpack.config.js index 65d10b6e04b..94d66e448ef 100644 --- a/webpack.config.js +++ b/webpack.config.js @@ -22,7 +22,7 @@ module.exports = { } }, { test: /\.js$/, - include: /node_modules[\\\/]buffer[\\\/]/, + include: /node_modules[\\\/](buffer|is-mobile)[\\\/]/, use: { loader: 'babel-loader', options: { From 930739b6c5af73507ddfbab0bbd468def1d96b42 Mon Sep 17 00:00:00 2001 From: Mojtaba Samimi Date: Thu, 12 Jan 2023 10:53:37 -0500 Subject: [PATCH 2/3] move no-new-func test to run in the end --- .circleci/config.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index bdec4b31d6d..89e8c8be568 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -403,15 +403,15 @@ jobs: - run: name: Test plotly.min.js import using requirejs command: npm run test-requirejs + - run: + name: Test plotly bundles against es6 + command: npm run no-es6-dist - run: name: Display function constructors in all bundles (only on master) command: | if [ $CIRCLE_BRANCH == "master" ] then npm run no-new-func fi - - run: - name: Test plotly bundles against es6 - command: npm run no-es6-dist workflows: version: 2 From 30d0a993bd0c1020c37e1232d3d8d3d0a474e0b1 Mon Sep 17 00:00:00 2001 From: Mojtaba Samimi Date: Thu, 12 Jan 2023 10:55:04 -0500 Subject: [PATCH 3/3] run no-new-func on dev branches - it catches es6 syntax e.g. const --- .circleci/config.yml | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 89e8c8be568..5a38ad3964d 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -407,11 +407,8 @@ jobs: name: Test plotly bundles against es6 command: npm run no-es6-dist - run: - name: Display function constructors in all bundles (only on master) - command: | - if [ $CIRCLE_BRANCH == "master" ] - then npm run no-new-func - fi + name: Display function constructors in all bundles + command: npm run no-new-func workflows: version: 2