Merge pull request #780 from plotly/hot-fix-add-trace

Hot fix add trace

Author: VeraZab

package.json

@@ -1,7 +1,7 @@
 {
   "name": "react-chart-editor",
   "description": "plotly.js chart editor react component UI",
-  "version": "0.33.0",
+  "version": "0.33.1",
   "author": "Plotly, Inc.",
   "bugs": {
     "url": "https://github.com/plotly/react-chart-editor/issues"
@@ -125,4 +125,4 @@
     "watch": "babel src --watch --out-dir lib --source-maps | node-sass -w src/styles/main.scss lib/react-chart-editor.css",
     "watch-test": "jest --watch"
   }
-}
+}

scripts/translationKeys/combined-translation-keys.txt

@@ -156,7 +156,10 @@ class EditorControls extends Component {
           const prevTrace = graphDiv.data[graphDiv.data.length - 1];
           const prevTraceType = plotlyTraceToCustomTrace(prevTrace);
           graphDiv.data.push(
-            traceTypeToPlotlyInitFigure(prevTraceType, prevTrace.type.endsWith('gl') ? 'gl' : '')
+            traceTypeToPlotlyInitFigure(
+              prevTraceType,
+              prevTrace.type && prevTrace.type.endsWith('gl') ? 'gl' : ''
+            )
           );
         }
 

scripts/translationKeys/translation-keys.txt

@@ -83,7 +83,7 @@ class TraceTypeSelector extends Component {
     } = this.props;
     const computedValue = traceTypeToPlotlyInitFigure(value);
     if (
-      (type.endsWith('gl') || (!TRACES_WITH_GL.includes(type) && glByDefault)) &&
+      ((type && type.endsWith('gl')) || (!TRACES_WITH_GL.includes(type) && glByDefault)) &&
       TRACES_WITH_GL.includes(computedValue.type) &&
       !computedValue.type.endsWith('gl')
     ) {

src/EditorControls.js

@@ -32,11 +32,15 @@ export function plotlyTraceToCustomTrace(trace) {
 }
 
 export function traceTypeToPlotlyInitFigure(traceType, gl = '') {
+  const scatterTrace = {type: 'scatter' + gl, mode: 'markers', stackgroup: null};
+
   switch (traceType) {
     case 'line':
       return {type: 'scatter' + gl, mode: 'lines', stackgroup: null};
     case 'scatter':
-      return {type: 'scatter' + gl, mode: 'markers', stackgroup: null};
+      return scatterTrace;
+    case undefined: // eslint-disable-line
+      return scatterTrace;
     case 'area':
       return {type: 'scatter' + gl, mode: 'lines', stackgroup: 1};
     case 'scatterpolar':