Skip to content

Fix Memory leak in make loop #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 26, 2018
Merged

Fix Memory leak in make loop #12

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
19888f4
use tailRecM in make loopthis shuold avoid Memory leak #10
safareli May 21, 2018
2ad741e
no need for `attempt`
safareli May 21, 2018
9896632
wrap forever with attempt
safareli May 21, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 7 additions & 9 deletions src/Control/Monad/Aff/Bus.purs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,9 @@ import Control.Monad.Aff.AVar (AVAR, AVar, killVar, makeEmptyVar, putVar, takeVa
import Control.Monad.Eff.AVar as EffAvar
import Control.Monad.Eff.Class (class MonadEff, liftEff)
import Control.Monad.Eff.Exception as Exn
import Control.Monad.Rec.Class (forever)
import Data.Foldable (foldl, sequence_, traverse_)
import Data.List (List, (:))
import Data.List (List(..), (:))
import Data.Monoid (mempty)
import Data.Tuple (Tuple(..))

Expand All @@ -60,14 +61,11 @@ make ∷ ∀ m eff a. MonadEff (avar ∷ AVAR | eff) m => m (BusRW a)
make = liftEff do
cell ← EffAvar.makeEmptyVar
consumers ← EffAvar.makeVar mempty
let
loop = attempt (takeVar cell) >>= traverse_ \res → do
vars ← takeVar consumers
putVar mempty consumers
sequence_ (foldl (\xs a → putVar res a : xs) mempty vars)
loop
launchAff_ loop

launchAff_ $ attempt $ forever do
res ← takeVar cell
vars ← takeVar consumers
putVar Nil consumers
sequence_ (foldl (\xs a → putVar res a : xs) mempty vars)
pure $ Bus cell consumers

-- | Blocks until a new value is pushed to the Bus, returning the value.
Expand Down