Skip to content

Remove MonadCont instance #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 21, 2016
Merged

Remove MonadCont instance #75

merged 1 commit into from
Oct 21, 2016

Conversation

garyb
Copy link
Member

@garyb garyb commented Oct 21, 2016

Resolves #59, also resolves #46 since if there's no instance it can't be broken 😄

@jdegoes are you happy with this now? At the time I opened #59 you said to keep it around for a while longer.

@jdegoes
Copy link
Contributor

jdegoes commented Oct 21, 2016

Yes, let's do it! BREAK ALL THE THINGZ!!!

@garyb
Copy link
Member Author

garyb commented Oct 21, 2016

I'm not sure if it will actually break anyone's code anyway, the only use of the MonadCont instance I've seen in the wild was in the tests!

@garyb garyb merged commit 96e0140 into purescript-contrib:master Oct 21, 2016
@garyb garyb deleted the remove-monadcont branch October 21, 2016 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Remove MonadCont instance monadCont instance doesn't preserve cancellation behavior
2 participants