Skip to content

Rename and export stringify #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 9, 2016

Conversation

charleso
Copy link
Contributor

Apologies if there's a reason for not exporting this in the first place.

@garyb
Copy link
Member

garyb commented Jul 11, 2016

It's not exported directly because show is the same thing... show probably should be something else though, so that it fits the informal law of printing valid PS code, so 👍 I think.

@charleso
Copy link
Contributor Author

Yeah I don't like Show, it can cause subtle bugs when types change. :)

@damncabbage
Copy link

In case it's useful: the opening post of purescript/purescript#1675 lays out the objection to enforcing the use of Show pretty well:

The more types that do have Show instances, the more dangerous show becomes; given that it works on almost anything, and that the return type is just String (rather than something that mentions the input type like pure, for example) it's very easy to call show on the wrong thing. It's almost like using a dynamic language!

@garyb
Copy link
Member

garyb commented Aug 9, 2016

Oops, sorry this was left to languish!

@garyb garyb merged commit ab2016d into purescript-contrib:master Aug 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants