Skip to content

Update codecs dependency #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 9, 2018
Merged

Update codecs dependency #11

merged 1 commit into from
Nov 9, 2018

Conversation

LiamGoodacre
Copy link
Member

Now that -codecs includes instances of EncodeJson and DecodeJson for records, we don't need to special case record arguments here! ✨

@thomashoneyman
Copy link
Contributor

Thanks for doing this, @LiamGoodacre! I noticed that the CI build doesn't run the tests by default, so I ran them locally and things look OK. I'd like to add that step to the formal CI config before merging, however, for sanity's sake.

-- | and values from the given record into a Json-`Object`
-- | the field in question is indicated by the head of the `RowList`
-- |
-- | the `Nil` case just returns `identity` to bootstrap the composition-chain
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always good to get rid of this boilerplate

@thomashoneyman
Copy link
Contributor

I'm merging this with a minor release, and since your next PR has a breaking API change that'll go in a major bump.

@thomashoneyman thomashoneyman merged commit bc448ab into purescript-contrib:master Nov 9, 2018
@thomashoneyman
Copy link
Contributor

This has been replaced in master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants