Update codecs dependency #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for doing this, @LiamGoodacre! I noticed that the CI build doesn't run the tests by default, so I ran them locally and things look OK. I'd like to add that step to the formal CI config before merging, however, for sanity's sake. |
| -- | and values from the given record into a Json-`Object` | ||
| -- | the field in question is indicated by the head of the `RowList` | ||
| -- | | ||
| -- | the `Nil` case just returns `identity` to bootstrap the composition-chain |
There was a problem hiding this comment.
Always good to get rid of this boilerplate
|
I'm merging this with a minor release, and since your next PR has a breaking API change that'll go in a major bump. |
|
This has been replaced in master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that -codecs includes instances of EncodeJson and DecodeJson for records, we don't need to special case record arguments here! ✨