updated to PureScript 0.12 #8
Conversation
- updated dependencies - replaced removed `Generic.Rep` cases/fields with a `RowToList` approach
| -- | JSON in to the resulting record value | ||
| -- | | ||
| -- | `from` and `to` indicates the the step the `Builder` will take from a `Record from` | ||
| -- | to a `Record to` so for a given `RowList` `from` will be the empty record |
There was a problem hiding this comment.
If from is always an empty record, then why is it variable here?
There was a problem hiding this comment.
I think there is a misunderstanding.
I do understand how this works. I've already spent time to understand it, and also I happen to have written similar things multiple times before.
The comment is not for me, but for future audience. Maintainability, you know.
There was a problem hiding this comment.
oh shit sorry - maybe you can help me out with the wording here then
There was a problem hiding this comment.
I'm really only trying to help - of course you know this ...
anyway can you have a look at it now? I hope the confusing pieces are gone and it's more obvious why to use this(?)
There was a problem hiding this comment.
Don't worry too much about it, I only suggested.
I think this comment is great.
| -- | JSON in to the resulting record value | ||
| -- | | ||
| -- | `from` and `to` indicates the the step the `Builder` will take from a `Record from` | ||
| -- | to a `Record to` so for a given `RowList` `from` will be the empty record |
There was a problem hiding this comment.
Don't worry too much about it, I only suggested.
I think this comment is great.
|
@fsoikin Since you've got an approved review in, I'll merge this tomorrow unless you have any objections. Thanks @CarstenKoenig for your work! |
|
thank you! |
|
No objections, please merge. Thank you! :-) |
|
👍 |
What does this pull request do?
Generic.Repcases/fields with aRowToListapproachWhere should the reviewer start?
the relevant changes should be in
Data.Argonaut.Decode.Generic.RepandData.Argonaut.Encode.Generic.RepHow should this be manually tested?
or
should do
Other Notes:
this is a cleaned up version from this PR: #6 (review)