Skip to content

round up 1's digit in the number formatter #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ntwilson
Copy link
Contributor

Fixes #55
My first PR for PureScript, so some solid reviews would help!

@thomashoneyman thomashoneyman self-assigned this Aug 17, 2020
Copy link
Contributor

@thomashoneyman thomashoneyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thank you!

@thomashoneyman thomashoneyman merged commit 94a4a5c into purescript-contrib:master Aug 22, 2020
@thomashoneyman
Copy link
Contributor

thomashoneyman commented Aug 22, 2020

@ntwilson great first contribution 🥇🎊!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Rounding up to next 1's digit bug
2 participants