Skip to content

Support lower-case meridiem #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

fsoikin
Copy link

@fsoikin fsoikin commented Feb 24, 2021

Description of the change
Adds support for lower-case meridiem (i.e. "am" or "pm" instead of "AM" and "PM") via a new FormatterCommand constructor MeridiemLowerCase and its string representation "A".

This is something our designers really want to have, and so far we have been doing a combination of ignoring the designers' requests and/or separately lowercasing the resulting string. The latter is not always possible, e.g. in case the string contains month or week day name, which can be worked around by formatting those separately and concatenating, but this kind of defeats the point of using a formatter library in the first place.

The print-parse-print loop doesn't work - it will lose the lower-case variant upon parsing, - but then it never did work in this respect, so no harm.


Checklist:

  • Added the change to the changelog's "Unreleased" section with a link to this PR and your username
  • N/A Linked any existing issues or proposals that this pull request should close
  • Updated or added relevant documentation in the README and/or documentation directory
  • Added a test for the contribution (if applicable)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant