Support lower-case meridiem #67
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Adds support for lower-case meridiem (i.e. "am" or "pm" instead of "AM" and "PM") via a new
FormatterCommand
constructorMeridiemLowerCase
and its string representation"A"
.This is something our designers really want to have, and so far we have been doing a combination of ignoring the designers' requests and/or separately lowercasing the resulting string. The latter is not always possible, e.g. in case the string contains month or week day name, which can be worked around by formatting those separately and concatenating, but this kind of defeats the point of using a formatter library in the first place.
The print-parse-print loop doesn't work - it will lose the lower-case variant upon parsing, - but then it never did work in this respect, so no harm.
Checklist:
Linked any existing issues or proposals that this pull request should close