I think we should do something consistent with other enum strings like TextAlign. I don't particularly like the TextAlign solution of using Show, so I suggest both data types get changed to have a (valid) Show instance, and a helper function to convert to their string values.

But that can be another commit. This looks good to merge.

Thanks!

Thanks for merging this. I can add the Show instance for PatternRepeat. For the helper, what would you call that, toString?

Sounds good.

Sent from my iPhone

On Mar 9, 2016, at 10:07 PM, Ingmar Gagen [email protected] wrote:

In src/Graphics/Canvas.purs:

@@ -471,6 +479,21 @@ foreign import drawImageScale :: forall eff. Context2D -> CanvasImageSource -> N

foreign import drawImageFull :: forall eff. Context2D -> CanvasImageSource -> Number -> Number -> Number -> Number -> Number -> Number -> Number -> Number -> Eff (canvas :: Canvas | eff) Context2D

+-- | Enumerates the different types of pattern repetitions.
+data PatternRepeat = Repeat | RepeatX | RepeatY | NoRepeat
+
+foreign import createPatternImpl :: forall eff. CanvasImageSource -> String -> Context2D -> Eff (canvas :: Canvas | eff) CanvasPattern
+
+-- | Create a new canvas pattern (repeatable image).
+createPattern :: forall eff. CanvasImageSource -> PatternRepeat -> Context2D -> Eff (canvas :: Canvas | eff) CanvasPattern
+createPattern img Repeat = createPatternImpl img "repeat"
Thanks for merging this. I can add the Show instance for PatternRepeat. For the helper, what would you call that, toString?

—
Reply to this email directly or view it on GitHub.