Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #22. All I added was generic deriving for the rest of the types in src/Date. I added some question in #22, so I guess I'll add them here as well to maybe keep the discussion going.
What offset/timezone support do you think would be most beneficial? Is it the plan here to incorporate this whole body of (notoriously tricky) offset/timezone logic like a library like moment.js does?
Would it be a possibility to merge this PR as it is now and hold off on the move to a newtype around Milliseconds + timezone/offset? Or do you think that's a bad idea?