Skip to content

Specific integers #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Specific integers #54

wants to merge 3 commits into from

Conversation

JamieBallingall
Copy link

@JamieBallingall JamieBallingall commented Jul 20, 2022 •
edited
Loading

Add two constant values: minInt and maxInt. Similar in spirit to PR #48 but provides the bounds on 32-bit signed integers (i.e., the Int type) as Int rather than referencing Javascript's concept of minimum and maximum integers.

Checklist:

  • Added the change to the changelog's "Unreleased" section with a reference to this PR (e.g. "- Made a change (#0000)")
  • Linked any existing issues or proposals that this pull request should close
  • Updated or added relevant documentation
  • Added a test for the contribution (if applicable)

@JamieBallingall
Copy link
Author

I just realized that Int has a perfectly good Bounded instance, so minInt and maxInt are redundant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@JamieBallingall