NonExistentTimeError when calling hour_angle #2132
Description
Describe the bug
Cannot compute hour_angle in timezones and on a day where a daylight savings transition happens at midnight.
To Reproduce
from datetime import datetime, timedelta
import pytz
import pandas as pd
import pvlib
date = datetime(2014, 9, 7, 0, 0, 0, tzinfo=pytz.UTC)
times = pd.DatetimeIndex(
[date + timedelta(hours=hour) for hour in range(24)]
).tz_convert("America/Santiago")
day_of_year = date.timetuple().tm_yday
equation_of_time = pvlib.solarposition.equation_of_time_spencer71(day_of_year)
declination = pvlib.solarposition.declination_spencer71(day_of_year)
hour_angle = pvlib.solarposition.hour_angle(
times, 70.6693, equation_of_time
)The call to times.normalize() inside hour_angle raises an exception:
pytz.exceptions.NonExistentTimeError: 2014-09-07 00:00:00
Expected behavior
I'm not entirely sure. Pandas' tz_localize includes arguments for handling these sort of situations (https://pandas.pydata.org/docs/reference/api/pandas.Series.dt.tz_localize.html) and I suspect we could normalize the times like this:
tz = times.tz
normalized_times = times.tz_localize(None).normalize().tz_localize(tz, nonexistent="shift_forward")This would normalize the times to 1:00am instead of 12:00am (which didn't exist on that date). Here's some related discussion from a Pandas issue: pandas-dev/pandas#40517
I suspect we'd need to similarly handle ambiguous times when daylight savings ends.
Does this seem like a reasonable approach? I can put a small PR together if so.
Versions:
pvlib.__version__: 0.10.5pandas.__version__: 2.2.2- python: 3.11.7